[flang] Expand coverage of co_sum unit test

[rouson]

Summary

This patch makes the co_sum test more similar to the other collectives tests by

1. Adding 'a' argument types,
2. Varying the 'a' argument types more frequently throughout the test,
3. Clarifying the To Do comment, and
4. Replacing several "to be determined" error messages

[ktras]

flang/test/Semantics/collectives01.f90

43

There is a trailing comma in the argument list.

[ktras]

Please update some of the expected error messages as I suggest in the inline comments. Please also replace the ‘ character with ' where they exist in the expected error messages.

flang/test/Semantics/collectives01.f90

71

72

76

[ktras]

This patch does a great job of expanding coverage by testing many more possibilities for correct and incorrect calls. One additional check could be to add a co_sum call which contains the optional arguments, but not the required a argument. Also, I see that you check that the intent-spec of the a argument is not being violated, but stat and errmsg also have to be intent(out) and intent(inout), respectively, and additional checks for those could be added.

[rouson]

1. Fixed on typo: removed a trailing comma.
2. Added check for missing mandatory 'a' argument.
3. Added test for 'stat' argument intent(out) .
4. Added check for 'errmsg' argument intent(inout).
5. Replaced non-standard single-quote characters.

[ktras]

The updated patch based on feedback looks great! LGTM.

[rouson]

I forgot to put the differential number in my commit message for commit e065570. How do I close this differential?

flang/test/Semantics/collectives01.f90

 ! RUN: %python %S/test_errors.py %s %flang_fc1
 ! XFAIL: *
-! Check for semantic errors in co_sum() subroutine calls
-! To Do: add co_sum to the evaluation stage
+! This test checks for semantic errors in co_sum subroutine calls based on
+! the co_reduce interface defined in section 16.9.50 of the Fortran 2018 standard.
+! To Do: add co_sum to the list of intrinsics
 
-module test_co_sum
+program test_co_sum
   implicit none
 
-contains
+  integer i, status, integer_array(1), coindexed_integer[*]
+  complex c, complex_array(1,1,1, 1,1,1, 1,1,1, 1,1,1, 1,1,1) 
+  double precision d, double_precision_array(1)
+  real r, real_array(1), coindexed_real[*]
 
-  subroutine test
+  character(len=1) message, coindexed_character[*], character_array(1)
+  logical bool
   
-    integer i, status
-    real array(1)
-    complex z(1,1,1, 1,1,1, 1,1,1, 1,1,1, 1,1,1) 
-    character(len=1) message
-  
-    ! correct calls, should produce no errors
-    call co_sum(i)
-    call co_sum(i,   1)
-    call co_sum(i,   1,              status)
-    call co_sum(i,   1,              stat=status)
-    call co_sum(i,   1,                           errmsg=message)
-    call co_sum(i,   1,              stat=status, errmsg=message)
-    call co_sum(i,   result_image=1, stat=status, errmsg=message)
-    call co_sum(a=i, result_image=1, stat=status, errmsg=message)
-    call co_sum(i,   result_image=1, stat=status, errmsg=message)
-  
-    call co_sum(array, result_image=1, stat=status, errmsg=message)
-    call co_sum(z, result_image=1, stat=status, errmsg=message)
+  !___ standard-conforming calls with no keyword arguments ___
+  call co_sum(c)
+  call co_sum(d)
+  call co_sum(r)
+  call co_sum(i, 1)
+  call co_sum(c, 1, status)
+  call co_sum(d, 1, status, message)
+  call co_sum(r, 1, status, message)
+  call co_sum(integer_array)
+  call co_sum(complex_array, 1)
+  call co_sum(double_precision_array, 1, status)
+  call co_sum(real_array, 1, status, message)
+
+  !___ standard-conforming calls with keyword arguments ___
+
+  ! all arguments present
+  call co_sum(a=i, result_image=1, stat=status, errmsg=message) 
+  ! one optional argument not present
+  call co_sum(a=i,                 stat=status, errmsg=message) 
+  call co_sum(a=i, result_image=1,              errmsg=message)
+  call co_sum(a=i, result_image=1, stat=status                )
+
+  ! two optional arguments not present
+  call co_sum(a=i, result_image=1                             ) 
+  call co_sum(a=i,                 stat=status                )
+  call co_sum(a=i,                              errmsg=message) 
+
+  ! no optional arguments present
+  call co_sum(a=i                                             ) 
+
+  !___ non-standard-conforming calls ___
+
+  !ERROR: missing mandatory 'a=' argument
+  call co_sum(result_image=1, stat=status, errmsg=message)
+
+  ! argument 'a' shall be of numeric type
+  !ERROR: Actual argument for 'a=' has bad type 'LOGICAL(4)'
+  call co_sum(bool)
   
-    ! the error is seen as an incorrect type for the stat= argument
-    !ERROR: Actual argument for 'stat=' has bad type 'CHARACTER(KIND=1,LEN=1_8)'
-    call co_sum(i, 1, message)
+  ! argument 'a' is intent(inout)
+  !ERROR: Actual argument associated with INTENT(IN OUT) dummy argument 'a=' must be definable
+  call co_sum(a=1+1)
+  
+  ! argument 'a' shall not be a coindexed object
+  !ERROR: to be determined
+  call co_sum(a=coindexed_real[1])
+  
+  ! 'result_image' argument shall be a integer
+  !ERROR: Actual argument for 'result_image=' has bad type 'LOGICAL(4)'
+  call co_sum(i, result_image=bool)
+  
+  ! 'result_image' argument shall be an integer scalar
+  !ERROR: 'result_image=' argument has unacceptable rank 1
+  call co_sum(c, result_image=integer_array)
+
+  ! argument 'stat' shall be intent(out)
+  !ERROR: Actual argument associated with INTENT(OUT) dummy argument 'stat=' must be definable
+  call co_sum(a=i, result_image=1, stat=1+1, errmsg=message)
+
+  ! 'stat' argument shall be noncoindexed
+  !ERROR: to be determined
+  call co_sum(d, stat=coindexed_integer[1])
+ 
+  ! 'stat' argument shall be an integer
+  call co_sum(r, stat=message)
+ 
+  ! 'stat' argument shall be an integer scalar
+  !ERROR: 'stat=' argument has unacceptable rank 1
+  call co_sum(i, stat=integer_array)
+ 
+  ! 'errmsg' argument shall be intent(inout)
+  !ERROR: Actual argument associated with INTENT(IN OUT) dummy argument 'errmsg=' must be definable
+  call co_sum(a=i, result_image=1, stat=status, errmsg='c')
+  
+  ! 'errmsg' argument shall be noncoindexed
+  !ERROR: to be determined
+  call co_sum(c, errmsg=coindexed_character[1])
+ 
+  ! 'errmsg' argument shall be character scalar
+  !ERROR: 'errmsg=' argument has unacceptable rank 1
+  call co_sum(d, errmsg=character_array)
  
-    ! the error is seen as too many arguments to the co_sum() call
-    !ERROR: too many actual arguments for intrinsic 'co_sum'
-    call co_sum(i,   result_image=1, stat=status, errmsg=message, 3.4)
+  call co_sum(r, result_image=1, stat=status, errmsg=message, 3.4)
   
-    ! keyword argument with incorrect type
-    !ERROR: unknown keyword argument to intrinsic 'co_sum'
-    call co_sum(fake=3.4)
+  ! keyword argument with incorrect name
   
-  end subroutine
-
-end module test_co_sum
+end program test_co_sum