This is an archive of the discontinued LLVM Phabricator instance.

[Sanitizer] Call StackDepotStopBackgroundThread() on all platforms
ClosedPublic

Authored by yln on Dec 20 2021, 3:49 PM.

Details

Summary

Call __sanitizer::StackDepotStopBackgroundThread() from
__sanitizer_sandbox_on_notify() on all platforms.

This should be gated on stack depot code availability, but not on
platform.

rdar://86347037

Diff Detail

Unit TestsFailed

Event Timeline

yln created this revision.Dec 20 2021, 3:49 PM
yln requested review of this revision.Dec 20 2021, 3:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 20 2021, 3:49 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
yln added a comment.Dec 20 2021, 3:53 PM

Fixes the failing test compress_stack_depot.cpp on Darwin.

kubamracek accepted this revision.Dec 20 2021, 4:04 PM
This revision is now accepted and ready to land.Dec 20 2021, 4:04 PM
yln updated this revision to Diff 395566.Dec 20 2021, 6:17 PM

Guard with #if !SANITIZER_GO.

Just noticed this review after pushing 80c95bbdf359c54abaeacdbcc070b7b5d3b25b6a
Almost the same but we can't do that on Windows