This is an archive of the discontinued LLVM Phabricator instance.

Differential D115963

[mlir][vscode] Highlight inside c++ raw strings
ClosedPublic

Authored by jpienaar on Dec 17 2021, 11:58 AM.

Details

Reviewers
mehdi_amini
Commits
rG2d4f3ed5517a: [mlir][vscode] Highlight inside c++ raw strings
Summary

Within C++ raw strings with mlir delimitter use MLIR syntax.

Diff Detail

Event Timeline

jpienaar created this revision.Dec 17 2021, 11:58 AM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 20 others. · View Herald TranscriptDec 17 2021, 11:58 AM
jpienaar requested review of this revision.Dec 17 2021, 11:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2021, 11:58 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
mehdi_amini accepted this revision.Dec 17 2021, 12:00 PM

Nice!

This revision is now accepted and ready to land.Dec 17 2021, 12:00 PM
Harbormaster completed remote builds in B139893: Diff 395191.Dec 17 2021, 12:37 PM
jpienaar updated this revision to Diff 395203.Dec 17 2021, 12:57 PM

Fixing clang-format warnings

This revision was landed with ongoing or failed builds.Dec 17 2021, 12:58 PM
Closed by commit rG2d4f3ed5517a: [mlir][vscode] Highlight inside c++ raw strings (authored by jpienaar). · Explain Why
This revision was automatically updated to reflect the committed changes.
jpienaar added a commit: rG2d4f3ed5517a: [mlir][vscode] Highlight inside c++ raw strings.
Harbormaster completed remote builds in B139902: Diff 395203.Dec 17 2021, 1:11 PM

Revision Contents

PathSize
mlir/
utils/
vscode/
44 lines
12 lines

Diff 395191

mlir/utils/vscode/cpp-grammar.json

  • This file was added.
{
"scopeName": "source.cpp.mlir",
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-    "scopeName": "source.cpp.mlir",
-    "injectionSelector": "L:source.cpp",
-    "patterns": [
-        {
-            "include": "#mlir-raw-string"
+  "scopeName": "source.cpp.mlir",
+  "injectionSelector": "L:source.cpp",
+  "patterns": [
+    {
+      "include": "#mlir-raw-string"

11 diff lines are omitted. See full path.

Lint: Pre-merge checks: clang-format: please reformat the code ``` - "scopeName": "source.cpp.mlir"…
"injectionSelector": "L:source.cpp",
"patterns": [
{
"include": "#mlir-raw-string"
}
],
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-    ],
-    "repository": {
-        "mlir-raw-string": {
-            "begin": "R\"(?i:mlir)(\\()",
-            "beginCaptures": {
-                "0": {
-                    "name": "punctuation.definition.string.begin.cpp"
-                },
-                "1": {
-                    "name": "mlir.delimeter.raw.string.cpp"

45 diff lines are omitted. See full path.

Lint: Pre-merge checks: clang-format: please reformat the code ``` - ], - "repository": { - "mlir-raw…
"repository": {
"mlir-raw-string": {
"begin": "R\"(?i:mlir)(\\()",
"beginCaptures": {
"0": {
"name": "punctuation.definition.string.begin.cpp"
},
"1": {
"name": "mlir.delimeter.raw.string.cpp"
}
},
"end": "\\)(?i:mlir)\"",
"endCaptures": {
"0": {
"name": "punctuation.definition.string.end.cpp"
},
"1": {
"name": "mlir.delimeter.raw.string.cpp"
}
},
"name": "mlir.raw.string.cpp",
"patterns": [
{
"contentName": "source.mlir",
"begin": "(?!\\G)",
"end": "(?i)(?=\\)mlir\")",
"patterns": [
{
"include": "source.mlir"
}
]
}
]
}
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

+      ]
Lint: Pre-merge checks: clang-format: please reformat the code ``` + ] ```
}
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

+  }
Lint: Pre-merge checks: clang-format: please reformat the code ``` + } ```
}

mlir/utils/vscode/package.json

{ {
"name": "vscode-mlir", "name": "vscode-mlir",
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-	"name": "vscode-mlir",
-	"displayName": "MLIR",
-	"description": "MLIR Language Extension",
-	"version": "0.0.3",
-	"publisher": "llvm-vs-code-extensions",
-	"homepage": "https://mlir.llvm.org/",
-	"icon": "icon.png",
-	"engines": {
-		"vscode": "^1.52.0"
-	},

242 diff lines are omitted. See full path.

Lint: Pre-merge checks: clang-format: please reformat the code ``` - "name": "vscode-mlir", - "displayName": "MLIR"…
"displayName": "MLIR", "displayName": "MLIR",
"description": "MLIR Language Extension", "description": "MLIR Language Extension",
"version": "0.0.2", "version": "0.0.3",
"publisher": "llvm-vs-code-extensions", "publisher": "llvm-vs-code-extensions",
"homepage": "https://mlir.llvm.org/", "homepage": "https://mlir.llvm.org/",
"icon": "icon.png", "icon": "icon.png",
"engines": { "engines": {
"vscode": "^1.52.0" "vscode": "^1.52.0"
}, },
"categories": [ "categories": [
"Programming Languages" "Programming Languages"
▲ Show 20 Lines • Show All 61 Lines • ▼ Show 20 Lines "grammars": [
"scopeName": "markdown.mlir.codeblock", "scopeName": "markdown.mlir.codeblock",
"path": "markdown-grammar.json", "path": "markdown-grammar.json",
"injectTo": [ "injectTo": [
"text.html.markdown" "text.html.markdown"
], ],
"embeddedLanguages": { "embeddedLanguages": {
"meta.embedded.block.mlir": "mlir" "meta.embedded.block.mlir": "mlir"
} }
},
{
"scopeName": "source.cpp.mlir",
"path": "./cpp-grammar.json",
"injectTo": [
"source.cpp"
],
"embeddedLanguages": {
"source.mlir": "mlir"
}
} }
], ],
"configuration": { "configuration": {
"type": "object", "type": "object",
"title": "MLIR", "title": "MLIR",
"properties": { "properties": {
"mlir.server_path": { "mlir.server_path": {
"scope": "resource", "scope": "resource",
Show All 28 Lines