This is an archive of the discontinued LLVM Phabricator instance.

Differential D115889

[dSYM][NFC] Add error test case for llvm-dwarfdump
ClosedPublic

Authored by ellis on Dec 16 2021, 10:24 AM.

Details

Reviewers
jhenderson
clayborg
Commits
rGea5ba474074d: [dSYM][NFC] Add error test case for llvm-dwarfdump
Summary

Add a test to llvm-dwarfdump to simply test that the error messages
make sense when passing bad .dSYMs.

Diff Detail

Unit TestsFailed

TimeTest
70 msx64 debian > LLVM.Bindings/Go::go.test

Event Timeline

ellis created this revision.Dec 16 2021, 10:24 AM
Herald added a reviewer: jhenderson. · View Herald TranscriptDec 16 2021, 10:24 AM
Herald added a subscriber: cmtice. · View Herald Transcript
ellis requested review of this revision.Dec 16 2021, 10:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 16 2021, 10:24 AM
Herald added subscribers: llvm-commits, MaskRay. · View Herald Transcript
ellis added a reviewer: clayborg.Dec 16 2021, 10:24 AM
Harbormaster completed remote builds in B139697: Diff 394919.Dec 16 2021, 11:38 AM
ellis added a comment.Dec 16 2021, 1:41 PM

For reference, these error messages were added in https://reviews.llvm.org/D115418

clayborg accepted this revision.Dec 16 2021, 3:07 PM
This revision is now accepted and ready to land.Dec 16 2021, 3:07 PM
This revision was landed with ongoing or failed builds.Dec 16 2021, 3:23 PM
Closed by commit rGea5ba474074d: [dSYM][NFC] Add error test case for llvm-dwarfdump (authored by ellis). · Explain Why
This revision was automatically updated to reflect the committed changes.
ellis added a commit: rGea5ba474074d: [dSYM][NFC] Add error test case for llvm-dwarfdump.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-dwarfdump/
10 lines

Diff 394919

llvm/test/tools/llvm-dwarfdump/errors.test

  • This file was added.
RUN: mkdir -p %t/empty.dSYM/Contents/Resources/DWARF
RUN: mkdir -p %t/malformed.dSYM/Contents/blah
RUN: not llvm-dwarfdump %t/empty.dSYM 2>&1 | FileCheck %s --check-prefix ERR1
RUN: not llvm-dwarfdump %t/malformed.dSYM 2>&1 | FileCheck %s --check-prefix ERR2
ERR1: error: {{.*}}.dSYM: no objects found in dSYM bundle
ERR2: error: {{.*}}.dSYM: expected directory 'Contents/Resources/DWARF' in dSYM bundle