[LNT] Fixed cPerf tests

[kpdev42]

Summary

Fixed binary mode for perf files.
Fixed permission denied error while writing test perf files on some systems.
Disabled the test test_random_guff2. It works fine on Windows but causes a Bus Error (SIGBUS) on some Linux systems. It cannot be handled correctly in all cases.
Note we have no fib-aarch64 and fib2-aarch64 binaries to generate the full dump of the symbol table using objdump –t
We have generated fib-aarch64.objdump.out from fib-aarch64.nm.out manually to fix tests.

OS Laboratory. Huawei Russian Research Institute. Saint-Petersburg

[thopre]

On what system isn't the SIGBUS caught?

tests/testing/cPerf.py

221

./tests/testing/cPerf.py:223:1: E305 expected 2 blank lines after class or function definition, found 1

Add a newline after the end of the docstring.

[slydiman]

In D115703#3191755, @thopre wrote:

On what system isn't the SIGBUS caught?

I have reproduced it on Ubuntu 20.04 with python 3.9: bus error (core dumped).

[kpdev42]

Add a newline after the end of the docstring

[thopre]

LGTM

tests/testing/Inputs/fake-objdump.py

 import sys
 
 for a in sys.argv:
     if a.startswith('--start-address'):
         addr = a.split('=')[1]
 
         fname = '%s.%s.out' % (sys.argv[1], addr)
         sys.stdout.write(open(fname).read())
         sys.exit(0)
 
+    if a.startswith('-t'):
+        fname = '%s.out' % sys.argv[1]
+        sys.stdout.write(open(fname).read())
+        sys.exit(0)
+
 sys.exit(1)

tests/testing/Inputs/fib-aarch64.objdump.out

+00000000004017d8 l       .dynamic 00000000000001e0 .hidden _DYNAMIC
+00000000004019b8 l       .dynamic 0000000000000040 _GLOBAL_OFFSET_TABLE_
+00000000004007b0 l     F .text  0000000000000004 __libc_csu_fini
+0000000000400738 l     F .text  0000000000000078 __libc_csu_init
+00000000004005c0 l     F .text  0000000000000014 call_weak_fn
+00000000004006c8 l     F .text  0000000000000038 fib
+0000000000400700 g     F .text  0000000000000038 main

tests/testing/Inputs/fib2-aarch64.objdump.out

+00000000004017d8 l       .dynamic 00000000000001e0 .hidden _DYNAMIC
+00000000004019b8 l       .dynamic 0000000000000040 _GLOBAL_OFFSET_TABLE_
+00000000004007b0 l     F .text  0000000000000004 __libc_csu_fini
+0000000000400738 l     F .text  0000000000000078 __libc_csu_init
+00000000004005c0 l     F .text  0000000000000014 call_weak_fn
+00000000004006c8 l     F .text  0000000000000038 fib
+0000000000400700 g     F .text  0000000000000038 main

tests/testing/cPerf.py

class CPerfTest(unittest.TestCase):
     def _getInput(self, fname):
         return os.path.join(self.inputs, fname)
 
     def test_check_file(self):
         self.assertTrue(LinuxPerfProfile.checkFile(self._getInput('fib-aarch64.perf_data')))
 
     def test_aarch64_fib(self):
         perf_data = self._getInput('fib-aarch64.perf_data')
-        p = LinuxPerfProfile.deserialize(open(perf_data),
-                                         nm=self._getNm(perf_data),
+        p = LinuxPerfProfile.deserialize(open(perf_data, 'rb'),
                                          objdump=self._getObjdump(perf_data),
                                          propagateExceptions=True)
 
         self.assertEqual(p.data, self.expected_data['fib-aarch64'])
 
     def test_aarch64_fib2(self):
         perf_data = self._getInput('fib2-aarch64.perf_data')
-        p = LinuxPerfProfile.deserialize(open(perf_data),
-                                         nm=self._getNm(perf_data),
+        p = LinuxPerfProfile.deserialize(open(perf_data, 'rb'),
                                          objdump=self._getObjdump(perf_data),
                                          propagateExceptions=True)
 
         self.assertEqual(p.data, self.expected_data['fib2-aarch64'])
 
     def test_aarch64_fib2_nondynamic(self):
         perf_data = self._getInput('fib2-aarch64.perf_data')
-        p = LinuxPerfProfile.deserialize(open(perf_data),
-                                         nm=self._getNm(perf_data, True),
+        p = LinuxPerfProfile.deserialize(open(perf_data, 'rb'),
                                          objdump=self._getObjdump(perf_data),
                                          propagateExceptions=True)
 
         self.assertEqual(p.data, self.expected_data['fib2-aarch64'])
 
     def test_random_guff(self):
         # Create complete rubbish and throw it at cPerf, expecting an
         # AssertionError.
-        data = '6492gbiajng295akgjowj210441'
+        data = b'6492gbiajng295akgjowj210441'
         with tempfile.NamedTemporaryFile() as fd:
-            open(fd.name, 'w').write(data)
+            fd.write(data)
+            fd.seek(0)
             with self.assertRaises(AssertionError):
-                LinuxPerfProfile.deserialize(open(fd.name),
-                                             propagateExceptions=True)
+                LinuxPerfProfile.deserialize(fd, propagateExceptions=True)
 
+    """
+    This test causes a Bus Error (SIGBUS) which cannot be handled correctly.
     def test_random_guff2(self):
         # Create complete rubbish and throw it at cPerf, expecting an
         # AssertionError. This version contains the correct magic number.
-        data = 'PERFILE28620k hshjsjhs&6362kkjh25090nnjh'
+        data = b'PERFILE28620k hshjsjhs&6362kkjh25090nnjh'
         with tempfile.NamedTemporaryFile() as fd:
-            open(fd.name, 'w').write(data)
+            fd.write(data)
+            fd.seek(0)
             with self.assertRaises(AssertionError):
-                LinuxPerfProfile.deserialize(open(fd.name),
-                                             propagateExceptions=True)
-
+                LinuxPerfProfile.deserialize(fd, propagateExceptions=True)
+    """
 
 if __name__ == '__main__':
     unittest.main(argv=[sys.argv[0], ])