[OpenMP] Added codegen for allocate directive's 'align' clause.
Diff Detail
Diff Detail
Unit Tests
Unit Tests
Time | Test | |
---|---|---|
80 ms | x64 debian > LLVM.Bindings/Go::go.test |
Event Timeline
clang/lib/CodeGen/CGOpenMPRuntime.cpp | ||
---|---|---|
12311 | I would recommend to keep Expr * here rather than Value *. Value *Allocator might be not reachable here (with exceptions, especially), better to reemit it. |
Comment Actions
Thanks for catching that, Alexey. As suggested, we now keep the allocator Expr * and reemit it later when needed.
llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h | ||
---|---|---|
980–983 ↗ | (On Diff #394649) | Maybe I missed something but where is the definition of this member function? |
Comment Actions
Alexey, you weren't missing anything. This was an unnecessary declaration of createOMPAlignedAlloc OMPIRBuilder.h that I had forgotten to delete.
Comment Actions
Fixed format problem for test/OpenMP/allocate_codegen_attr.cpp
Successfully rebased, built, and tested.
Comment Actions
I've commit on your behalf in 7df2371bc6518a63bdbe5f3c44bd064940808e35 (Clang) and 7df2371bc6518a63bdbe5f3c44bd064940808e35 (LLVM). Thanks!
I would recommend to keep Expr * here rather than Value *. Value *Allocator might be not reachable here (with exceptions, especially), better to reemit it.