This is an archive of the discontinued LLVM Phabricator instance.

Differential D115621

[Debugify] Use WeakWH map collected before Pass when checking loc drop
ClosedPublic

Authored by djtodoro on Dec 13 2021, 3:26 AM.

Details

Reviewers
StephenTozer
Commits
rG93615b88f5aa: [Debugify] Use WeakWH map collected before Pass when checking loc drop
Summary

This fixes a typo/bug when checking for pointer reuse when testing DI location preservation in the Debugify original mode (when checking -g generated Debug Info).

Diff Detail

Unit TestsFailed

TimeTest
70 msx64 debian > LLVM.Bindings/Go::go.test

Event Timeline

djtodoro created this revision.Dec 13 2021, 3:26 AM
Herald added a subscriber: hiraditya. · View Herald TranscriptDec 13 2021, 3:26 AM
djtodoro requested review of this revision.Dec 13 2021, 3:26 AM
Herald added a subscriber: llvm-commits. · View Herald TranscriptDec 13 2021, 3:27 AM
djtodoro added a child revision: D115622: [Debugify] Optimize debugify original mode.Dec 13 2021, 3:38 AM
Harbormaster completed remote builds in B138925: Diff 393831.Dec 13 2021, 4:04 AM
StephenTozer accepted this revision.Dec 15 2021, 7:23 AM

Trivial fix, LGTM.

This revision is now accepted and ready to land.Dec 15 2021, 7:23 AM
This revision was landed with ongoing or failed builds.Dec 21 2021, 6:54 AM
Closed by commit rG93615b88f5aa: [Debugify] Use WeakWH map collected before Pass when checking loc drop (authored by djtodoro). · Explain Why
This revision was automatically updated to reflect the committed changes.
djtodoro added a commit: rG93615b88f5aa: [Debugify] Use WeakWH map collected before Pass when checking loc drop.

Revision Contents

PathSize
llvm/
lib/
Transforms/
Utils/
2 lines

Diff 393831

llvm/lib/Transforms/Utils/Debugify.cpp

Show First 20 Lines • Show All 590 Lines • ▼ Show 20 Lines StringRef FileNameFromCU =
->getFilename(); ->getFilename();
auto DIFunctionsBefore = DIPreservationMap[NameOfWrappedPass].DIFunctions; auto DIFunctionsBefore = DIPreservationMap[NameOfWrappedPass].DIFunctions;
auto DIFunctionsAfter = DIPreservationAfter[NameOfWrappedPass].DIFunctions; auto DIFunctionsAfter = DIPreservationAfter[NameOfWrappedPass].DIFunctions;
auto DILocsBefore = DIPreservationMap[NameOfWrappedPass].DILocations; auto DILocsBefore = DIPreservationMap[NameOfWrappedPass].DILocations;
auto DILocsAfter = DIPreservationAfter[NameOfWrappedPass].DILocations; auto DILocsAfter = DIPreservationAfter[NameOfWrappedPass].DILocations;
auto InstToDelete = DIPreservationAfter[NameOfWrappedPass].InstToDelete; auto InstToDelete = DIPreservationMap[NameOfWrappedPass].InstToDelete;
auto DIVarsBefore = DIPreservationMap[NameOfWrappedPass].DIVariables; auto DIVarsBefore = DIPreservationMap[NameOfWrappedPass].DIVariables;
auto DIVarsAfter = DIPreservationAfter[NameOfWrappedPass].DIVariables; auto DIVarsAfter = DIPreservationAfter[NameOfWrappedPass].DIVariables;
bool ShouldWriteIntoJSON = !OrigDIVerifyBugsReportFilePath.empty(); bool ShouldWriteIntoJSON = !OrigDIVerifyBugsReportFilePath.empty();
llvm::json::Array Bugs; llvm::json::Array Bugs;
bool ResultForFunc = bool ResultForFunc =
▲ Show 20 Lines • Show All 422 Lines • Show Last 20 Lines