Page MenuHomePhabricator

ntesic (Nikola Tesic)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 4 2019, 4:38 AM (80 w, 1 d)

Recent Activity

Jan 18 2021

ntesic added a comment to D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.

@ntesic Do you have commit access?

Jan 18 2021, 3:54 AM · Restricted Project, debug-info
ntesic updated the diff for D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.

Addressed comments:

  • Use shouldUpdateCallSiteInfo() predicate
  • Use ToErase->eraseFromParent()
  • Reduce function attributes in test
Jan 18 2021, 3:16 AM · Restricted Project, debug-info

Jan 14 2021

ntesic added a comment to D78105: [CSInfo][ISEL] Call site info generation support for Mips.
Jan 14 2021, 6:31 AM · Restricted Project, Restricted Project, debug-info
ntesic requested review of D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.
Jan 14 2021, 6:26 AM · Restricted Project, debug-info

Dec 9 2020

ntesic added a comment to D92471: [CSInfo] Do not create CSInfo for undef arguments.

@dstenb @djtodoro Sure, I will keep only one test.
Thanks for the review!

Dec 9 2020, 2:54 AM · Restricted Project, debug-info

Dec 3 2020

ntesic updated the diff for D92471: [CSInfo] Do not create CSInfo for undef arguments.
  • Move implementation to DwarfDebug
  • Update tests to check DWARF
Dec 3 2020, 4:31 AM · Restricted Project, debug-info
ntesic added a comment to D92471: [CSInfo] Do not create CSInfo for undef arguments.

I think it would be preferable if we could do this in a target independent place, so that downstream targets, and upstream targets that do not yet support call sites, do not have to care about this.

Can we do this in collectCallSiteParameters by looking at the call instruction's undef uses?

Something like this:

@@ -787,6 +787,15 @@ static void collectCallSiteParameters(const MachineInstr *CallMI,
     (void)InsertedReg;
   }
 
+  for (auto &MO : CallMI->uses()) {
+    if (!MO.isReg() || !MO.isUndef())
+      continue;
+    auto It = ForwardedRegWorklist.find(MO.getReg());
+    if (It == ForwardedRegWorklist.end())
+      continue;
+    ForwardedRegWorklist.erase(It);
+  }
+
Dec 3 2020, 4:29 AM · Restricted Project, debug-info

Dec 2 2020

ntesic requested review of D92471: [CSInfo] Do not create CSInfo for undef arguments.
Dec 2 2020, 2:12 AM · Restricted Project, debug-info

Jun 17 2020

ntesic created D82000: [CSInfo][MIPS] Don't describe parameters loaded by sub- or super- register copy.
Jun 17 2020, 3:44 AM · Restricted Project, debug-info

May 29 2020

ntesic added a comment to D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.

@dstenb Thanks for the review. Any additional comments?

May 29 2020, 4:18 AM · Restricted Project, debug-info

May 25 2020

ntesic updated the diff for D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.

Address comment - delaySlotSupported change.
Compress test-CHECK-lines.

May 25 2020, 8:33 AM · Restricted Project, debug-info
ntesic added a comment to D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.
May 25 2020, 8:33 AM · Restricted Project, debug-info
ntesic updated the diff for D78106: [CSInfo][NFC] Interpret loaded parameter value separately.

Clang format.

May 25 2020, 8:33 AM · Restricted Project, debug-info

May 22 2020

ntesic updated the diff for D78108: [CSInfo][MIPS] Describe parameter value loaded by ADDiu instruction.

Address comments.
Rebase.

May 22 2020, 3:01 AM · Restricted Project, debug-info

May 21 2020

ntesic updated the diff for D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.

Capture "&" instead of "this" in delaySlotSupported lambda.

May 21 2020, 7:31 AM · Restricted Project, debug-info
ntesic updated the diff for D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.

Address comments.
Change of delay slot guard - use assertions instead of target check.

May 21 2020, 6:59 AM · Restricted Project, debug-info
ntesic updated the diff for D78106: [CSInfo][NFC] Interpret loaded parameter value separately.

Address comments.
Transform lambda

nextInstrInterpret

into static function

interpretNextInstr
May 21 2020, 6:59 AM · Restricted Project, debug-info

May 15 2020

ntesic updated the diff for D78105: [CSInfo][ISEL] Call site info generation support for Mips.

Address comment - spelling.
Rebase.

May 15 2020, 12:52 AM · Restricted Project, Restricted Project, debug-info

May 14 2020

ntesic added a comment to D78105: [CSInfo][ISEL] Call site info generation support for Mips.

LGTM. Thanks!

Do you need help with landing this?

May 14 2020, 3:42 AM · Restricted Project, Restricted Project, debug-info
ntesic added a comment to D78105: [CSInfo][ISEL] Call site info generation support for Mips.
May 14 2020, 3:10 AM · Restricted Project, Restricted Project, debug-info
ntesic updated the summary of D78105: [CSInfo][ISEL] Call site info generation support for Mips.
May 14 2020, 3:10 AM · Restricted Project, Restricted Project, debug-info
ntesic updated the diff for D78105: [CSInfo][ISEL] Call site info generation support for Mips.

Address comments:

  • tests changes
  • patch summary update
May 14 2020, 2:39 AM · Restricted Project, Restricted Project, debug-info

May 12 2020

ntesic added inline comments to D78108: [CSInfo][MIPS] Describe parameter value loaded by ADDiu instruction.
May 12 2020, 6:57 AM · Restricted Project, debug-info
ntesic added a comment to D78105: [CSInfo][ISEL] Call site info generation support for Mips.
In D78105#2025646, @vsk wrote:

This seems to be in great shape. Does it have any dependencies?

May 12 2020, 1:02 AM · Restricted Project, Restricted Project, debug-info
ntesic updated the diff for D78105: [CSInfo][ISEL] Call site info generation support for Mips.

Address comment.
Tests update - use only one !DILocation per scope.

May 12 2020, 1:02 AM · Restricted Project, Restricted Project, debug-info

May 11 2020

ntesic added a comment to D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.

The main purpose of the "delay slot guard" is to ensure that call_site DIE won't be created for call with delay slot, because it could have incorrect "return PC" value (DW_AT_low_pc, DW_AT_call_return_pc).
This will happen if the call and its delay slot instruction are not in the expected order.

May 11 2020, 6:24 AM · Restricted Project, debug-info

May 4 2020

ntesic added inline comments to D78106: [CSInfo][NFC] Interpret loaded parameter value separately.
May 4 2020, 7:59 AM · Restricted Project, debug-info
ntesic updated the diff for D78106: [CSInfo][NFC] Interpret loaded parameter value separately.

Address comment.

May 4 2020, 7:59 AM · Restricted Project, debug-info

Apr 28 2020

ntesic updated the diff for D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.

Address comments.
@dstenb @djtodoro Thanks for your suggestions.

Apr 28 2020, 3:43 AM · Restricted Project, debug-info
ntesic updated the diff for D78106: [CSInfo][NFC] Interpret loaded parameter value separately.

Address comments.

Apr 28 2020, 3:11 AM · Restricted Project, debug-info
ntesic added inline comments to D78106: [CSInfo][NFC] Interpret loaded parameter value separately.
Apr 28 2020, 3:11 AM · Restricted Project, debug-info

Apr 24 2020

ntesic abandoned D78104: [CSInfo][clang] Enable debug entry values for Mips.

Merging into https://reviews.llvm.org/D78105.

Apr 24 2020, 5:54 AM · debug-info
ntesic added inline comments to D78105: [CSInfo][ISEL] Call site info generation support for Mips.
Apr 24 2020, 5:54 AM · Restricted Project, Restricted Project, debug-info
ntesic updated the diff for D78105: [CSInfo][ISEL] Call site info generation support for Mips.

Address comment.
Add changes from https://reviews.llvm.org/D78104.

Apr 24 2020, 5:54 AM · Restricted Project, Restricted Project, debug-info

Apr 23 2020

ntesic updated the diff for D78108: [CSInfo][MIPS] Describe parameter value loaded by ADDiu instruction.

Address comments.

Apr 23 2020, 5:53 AM · Restricted Project, debug-info
ntesic added inline comments to D78108: [CSInfo][MIPS] Describe parameter value loaded by ADDiu instruction.
Apr 23 2020, 5:53 AM · Restricted Project, debug-info
ntesic updated the diff for D78106: [CSInfo][NFC] Interpret loaded parameter value separately.

@dstenb
Thanks for the review.
I agree with all suggestions.

Apr 23 2020, 5:21 AM · Restricted Project, debug-info
ntesic added a comment to D78104: [CSInfo][clang] Enable debug entry values for Mips.

This would benefit from some kind of test.

Apr 23 2020, 5:21 AM · debug-info

Apr 14 2020

ntesic created D78108: [CSInfo][MIPS] Describe parameter value loaded by ADDiu instruction.
Apr 14 2020, 6:55 AM · Restricted Project, debug-info
ntesic created D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.
Apr 14 2020, 6:55 AM · Restricted Project, debug-info
ntesic created D78106: [CSInfo][NFC] Interpret loaded parameter value separately.
Apr 14 2020, 6:55 AM · Restricted Project, debug-info
ntesic created D78104: [CSInfo][clang] Enable debug entry values for Mips.
Apr 14 2020, 6:54 AM · debug-info
ntesic created D78105: [CSInfo][ISEL] Call site info generation support for Mips.
Apr 14 2020, 6:54 AM · Restricted Project, Restricted Project, debug-info

Nov 14 2019

ntesic added a watcher for debug-info: ntesic.
Nov 14 2019, 2:04 AM