Page MenuHomePhabricator

ntesic (Nikola Tesic)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 4 2019, 4:38 AM (30 w, 3 d)

Recent Activity

Fri, May 29

ntesic added a comment to D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.

@dstenb Thanks for the review. Any additional comments?

Fri, May 29, 4:18 AM · Restricted Project, debug-info

Mon, May 25

ntesic updated the diff for D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.

Address comment - delaySlotSupported change.
Compress test-CHECK-lines.

Mon, May 25, 8:33 AM · Restricted Project, debug-info
ntesic added a comment to D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.
Mon, May 25, 8:33 AM · Restricted Project, debug-info
ntesic updated the diff for D78106: [CSInfo][NFC] Interpret loaded parameter value separately.

Clang format.

Mon, May 25, 8:33 AM · Restricted Project, debug-info

Fri, May 22

ntesic updated the diff for D78108: [CSInfo][MIPS] Describe parameter value loaded by ADDiu instruction.

Address comments.
Rebase.

Fri, May 22, 3:01 AM · Restricted Project, debug-info

Thu, May 21

ntesic updated the diff for D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.

Capture "&" instead of "this" in delaySlotSupported lambda.

Thu, May 21, 7:31 AM · Restricted Project, debug-info
ntesic updated the diff for D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.

Address comments.
Change of delay slot guard - use assertions instead of target check.

Thu, May 21, 6:59 AM · Restricted Project, debug-info
ntesic updated the diff for D78106: [CSInfo][NFC] Interpret loaded parameter value separately.

Address comments.
Transform lambda

nextInstrInterpret

into static function

interpretNextInstr
Thu, May 21, 6:59 AM · Restricted Project, debug-info

Fri, May 15

ntesic updated the diff for D78105: [CSInfo][ISEL] Call site info generation support for Mips.

Address comment - spelling.
Rebase.

Fri, May 15, 12:52 AM · Restricted Project, Restricted Project, debug-info

Thu, May 14

ntesic added a comment to D78105: [CSInfo][ISEL] Call site info generation support for Mips.

LGTM. Thanks!

Do you need help with landing this?

Thu, May 14, 3:42 AM · Restricted Project, Restricted Project, debug-info
ntesic added a comment to D78105: [CSInfo][ISEL] Call site info generation support for Mips.
Thu, May 14, 3:10 AM · Restricted Project, Restricted Project, debug-info
ntesic updated the summary of D78105: [CSInfo][ISEL] Call site info generation support for Mips.
Thu, May 14, 3:10 AM · Restricted Project, Restricted Project, debug-info
ntesic updated the diff for D78105: [CSInfo][ISEL] Call site info generation support for Mips.

Address comments:

  • tests changes
  • patch summary update
Thu, May 14, 2:39 AM · Restricted Project, Restricted Project, debug-info

Tue, May 12

ntesic added inline comments to D78108: [CSInfo][MIPS] Describe parameter value loaded by ADDiu instruction.
Tue, May 12, 6:57 AM · Restricted Project, debug-info
ntesic added a comment to D78105: [CSInfo][ISEL] Call site info generation support for Mips.
In D78105#2025646, @vsk wrote:

This seems to be in great shape. Does it have any dependencies?

Tue, May 12, 1:02 AM · Restricted Project, Restricted Project, debug-info
ntesic updated the diff for D78105: [CSInfo][ISEL] Call site info generation support for Mips.

Address comment.
Tests update - use only one !DILocation per scope.

Tue, May 12, 1:02 AM · Restricted Project, Restricted Project, debug-info

Mon, May 11

ntesic added a comment to D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.

The main purpose of the "delay slot guard" is to ensure that call_site DIE won't be created for call with delay slot, because it could have incorrect "return PC" value (DW_AT_low_pc, DW_AT_call_return_pc).
This will happen if the call and its delay slot instruction are not in the expected order.

Mon, May 11, 6:24 AM · Restricted Project, debug-info

May 4 2020

ntesic added inline comments to D78106: [CSInfo][NFC] Interpret loaded parameter value separately.
May 4 2020, 7:59 AM · Restricted Project, debug-info
ntesic updated the diff for D78106: [CSInfo][NFC] Interpret loaded parameter value separately.

Address comment.

May 4 2020, 7:59 AM · Restricted Project, debug-info

Apr 28 2020

ntesic updated the diff for D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.

Address comments.
@dstenb @djtodoro Thanks for your suggestions.

Apr 28 2020, 3:43 AM · Restricted Project, debug-info
ntesic updated the diff for D78106: [CSInfo][NFC] Interpret loaded parameter value separately.

Address comments.

Apr 28 2020, 3:11 AM · Restricted Project, debug-info
ntesic added inline comments to D78106: [CSInfo][NFC] Interpret loaded parameter value separately.
Apr 28 2020, 3:11 AM · Restricted Project, debug-info

Apr 24 2020

ntesic abandoned D78104: [CSInfo][clang] Enable debug entry values for Mips.

Merging into https://reviews.llvm.org/D78105.

Apr 24 2020, 5:54 AM · debug-info
ntesic added inline comments to D78105: [CSInfo][ISEL] Call site info generation support for Mips.
Apr 24 2020, 5:54 AM · Restricted Project, Restricted Project, debug-info
ntesic updated the diff for D78105: [CSInfo][ISEL] Call site info generation support for Mips.

Address comment.
Add changes from https://reviews.llvm.org/D78104.

Apr 24 2020, 5:54 AM · Restricted Project, Restricted Project, debug-info

Apr 23 2020

ntesic updated the diff for D78108: [CSInfo][MIPS] Describe parameter value loaded by ADDiu instruction.

Address comments.

Apr 23 2020, 5:53 AM · Restricted Project, debug-info
ntesic added inline comments to D78108: [CSInfo][MIPS] Describe parameter value loaded by ADDiu instruction.
Apr 23 2020, 5:53 AM · Restricted Project, debug-info
ntesic updated the diff for D78106: [CSInfo][NFC] Interpret loaded parameter value separately.

@dstenb
Thanks for the review.
I agree with all suggestions.

Apr 23 2020, 5:21 AM · Restricted Project, debug-info
ntesic added a comment to D78104: [CSInfo][clang] Enable debug entry values for Mips.

This would benefit from some kind of test.

Apr 23 2020, 5:21 AM · debug-info

Apr 14 2020

ntesic added a child revision for D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug: D78108: [CSInfo][MIPS] Describe parameter value loaded by ADDiu instruction.
Apr 14 2020, 7:27 AM · Restricted Project, debug-info
ntesic added a parent revision for D78108: [CSInfo][MIPS] Describe parameter value loaded by ADDiu instruction: D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.
Apr 14 2020, 7:27 AM · Restricted Project, debug-info
ntesic added a parent revision for D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug: D78106: [CSInfo][NFC] Interpret loaded parameter value separately.
Apr 14 2020, 7:27 AM · Restricted Project, debug-info
ntesic added a child revision for D78106: [CSInfo][NFC] Interpret loaded parameter value separately: D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.
Apr 14 2020, 7:27 AM · Restricted Project, debug-info
ntesic added a parent revision for D78106: [CSInfo][NFC] Interpret loaded parameter value separately: D78105: [CSInfo][ISEL] Call site info generation support for Mips.
Apr 14 2020, 7:27 AM · Restricted Project, debug-info
ntesic added a child revision for D78105: [CSInfo][ISEL] Call site info generation support for Mips: D78106: [CSInfo][NFC] Interpret loaded parameter value separately.
Apr 14 2020, 7:27 AM · Restricted Project, Restricted Project, debug-info
ntesic added a parent revision for D78105: [CSInfo][ISEL] Call site info generation support for Mips: D78104: [CSInfo][clang] Enable debug entry values for Mips.
Apr 14 2020, 7:27 AM · Restricted Project, Restricted Project, debug-info
ntesic added a child revision for D78104: [CSInfo][clang] Enable debug entry values for Mips: D78105: [CSInfo][ISEL] Call site info generation support for Mips.
Apr 14 2020, 7:27 AM · debug-info
ntesic created D78108: [CSInfo][MIPS] Describe parameter value loaded by ADDiu instruction.
Apr 14 2020, 6:55 AM · Restricted Project, debug-info
ntesic created D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.
Apr 14 2020, 6:55 AM · Restricted Project, debug-info
ntesic created D78106: [CSInfo][NFC] Interpret loaded parameter value separately.
Apr 14 2020, 6:55 AM · Restricted Project, debug-info
ntesic created D78104: [CSInfo][clang] Enable debug entry values for Mips.
Apr 14 2020, 6:54 AM · debug-info
ntesic created D78105: [CSInfo][ISEL] Call site info generation support for Mips.
Apr 14 2020, 6:54 AM · Restricted Project, Restricted Project, debug-info

Nov 14 2019

ntesic added a watcher for debug-info: ntesic.
Nov 14 2019, 2:04 AM