This is an archive of the discontinued LLVM Phabricator instance.

[lit] Pass the COMSPEC variable through to test processes on Windows
ClosedPublic

Authored by mstorsjo on Dec 8 2021, 10:47 AM.

Details

Summary

This variable is necessary for the system() function for running
external processes.

This is needes for some libcxx tests. With the current libcxx test
infrastructure, all OS environment variables are passed through, but
with the new "from scratch" libcxx test setup, we only pass through
the variables listed here.

Diff Detail

Event Timeline

mstorsjo created this revision.Dec 8 2021, 10:47 AM
mstorsjo requested review of this revision.Dec 8 2021, 10:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 8 2021, 10:47 AM
hans accepted this revision.Dec 8 2021, 11:11 AM

lgtm

This revision is now accepted and ready to land.Dec 8 2021, 11:11 AM
This revision was landed with ongoing or failed builds.Dec 8 2021, 1:30 PM
This revision was automatically updated to reflect the committed changes.