This is an archive of the discontinued LLVM Phabricator instance.

Differential D115075

[ASan] Added asan_shadow_defines.h, which contatins shadow offset for various platforms.
AbandonedPublic

Authored by kstoimenov on Dec 3 2021, 1:15 PM.

Details

Reviewers
vitalybuka
Commits
rG2f3bb59f512f: [ASan] Added asan_shadow_defines.h, which contatins shadow offset for various…

Diff Detail

Event Timeline

kstoimenov created this revision.Dec 3 2021, 1:15 PM
Herald added subscribers: luke957, s.egerton, simoncook and 2 others. · View Herald TranscriptDec 3 2021, 1:15 PM
kstoimenov requested review of this revision.Dec 3 2021, 1:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2021, 1:15 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
kstoimenov mentioned this in D114558: [ASan] Shared optimized callbacks implementation..Dec 3 2021, 1:18 PM
vitalybuka added inline comments.Dec 3 2021, 1:27 PM
compiler-rt/lib/asan/asan_mapping.h
33–35

can you do just
if SHADOW_OFFSET_CONST
define SHADOW_OFFSET kConstShadowOffset
esle
define SHADOW_OFFSET __asan_shadow_memory_dynamic_address

vitalybuka added inline comments.Dec 3 2021, 1:30 PM
compiler-rt/lib/asan/asan_mapping.h
23–24

constexpr?

vitalybuka added a child revision: D114558: [ASan] Shared optimized callbacks implementation..Dec 3 2021, 1:31 PM
vitalybuka added inline comments.Dec 3 2021, 1:38 PM
compiler-rt/lib/asan/asan_shadow_defines.h
191

It was 0x7FFFFFFF & (~0xFFFULL << kDefaultShadowScale);
you need to use
#if defined(ASAN_SHADOW_SCALE) here

vitalybuka added inline comments.Dec 3 2021, 1:41 PM
compiler-rt/lib/asan/asan_shadow_defines.h
191

or we can remove COMPILER_RT_ASAN_SHADOW_SCALE and ASAN_SHADOW_SCALE, it's should be unused after related code was removed

Harbormaster completed remote builds in B137421: Diff 391721.Dec 3 2021, 1:43 PM
kstoimenov updated this revision to Diff 391743.Dec 3 2021, 2:44 PM
kstoimenov marked an inline comment as done.

Addressed comments.

kstoimenov marked 3 inline comments as done.Dec 3 2021, 2:46 PM
kstoimenov added inline comments.
compiler-rt/lib/asan/asan_mapping.h
23–24

I prefer to update the whole file in a separate patch.

33–35

I like that idea.

compiler-rt/lib/asan/asan_shadow_defines.h
191

I added an error message if ASAN_SHADOW_SCALE != 3.

191

Removing ASAN_SHADOW_SCALE is another clean up patch I think.

Harbormaster completed remote builds in B137438: Diff 391743.Dec 3 2021, 3:03 PM
vitalybuka added inline comments.Dec 3 2021, 3:13 PM
compiler-rt/lib/asan/asan_shadow_defines.h
161

0x0aaa0000 for better alignment

168

SANITIZER_IOS 32bit

  1. define SHADOW_OFFSET __asan_shadow_memory_dynamic_address
175

kRiscv64_ShadowOffset64 = 0xd55550000;

176

SANITIZER_MAC && defined(aarch64) should be __asan_shadow_memory_dynamic_address

also SANITIZER_WINDOWS64 __asan_shadow_memory_dynamic_address

187

this one was u64 kDefaultShadowOffset64 = 1ULL << 44
or 0x100000000000

190

we lost

#  elif defined(__sparc__)
#    define SHADOW_OFFSET_CONST 0x80000000000
vitalybuka added inline comments.Dec 3 2021, 3:16 PM
compiler-rt/lib/asan/asan_shadow_defines.h
175

it would be nice if you align all these to 8bytes with leading 0s as well

kstoimenov updated this revision to Diff 392061.Dec 6 2021, 7:39 AM
kstoimenov marked 8 inline comments as done.

Addressed comments.

kstoimenov updated this revision to Diff 392063.Dec 6 2021, 7:45 AM

Updated Fuchsia.

compiler-rt/lib/asan/asan_shadow_defines.h
168

Removed.

187

I added an error message for this.

Harbormaster completed remote builds in B137660: Diff 392063.Dec 6 2021, 8:28 AM
vitalybuka accepted this revision.Dec 6 2021, 11:46 AM
vitalybuka added inline comments.
compiler-rt/lib/asan/asan_shadow_defines.h
175

it would be nice if you align all these to 8bytes with leading 0s as well

You call, but I expected 64bit values like this: 0x0d55550000 -> 0x0000000d55550000

176

This one is not done?

187

this one was u64 kDefaultShadowOffset64 = 1ULL << 44

I added an error message for this.

I see you fixed the constant. What does this reply mean here?

This revision is now accepted and ready to land.Dec 6 2021, 11:46 AM
Closed by commit rG2f3bb59f512f: [ASan] Added asan_shadow_defines.h, which contatins shadow offset for various… (authored by kstoimenov). · Explain WhyDec 6 2021, 1:45 PM
This revision was automatically updated to reflect the committed changes.
kstoimenov added a commit: rG2f3bb59f512f: [ASan] Added asan_shadow_defines.h, which contatins shadow offset for various….
kstoimenov added a comment.Dec 6 2021, 1:59 PM

Sorry I didn't realize you have more comments before submitting it. Maybe you can send me a patch with the things that I missed in this one? Might be easier that way.

compiler-rt/lib/asan/asan_shadow_defines.h
176

Not sure what you mean by that.

187

I added this error:

  1. error "Only ASAN_SHADOW_SCALE = 3 is supported."
vitalybuka added inline comments.Dec 6 2021, 2:15 PM
compiler-rt/lib/asan/asan_shadow_defines.h
176

SANITIZER_MAC && defined(aarch64) had a different constant

kstoimenov added a reverting change: D115193: Revert "[ASan] Added asan_shadow_defines.h, which contatins shadow offset for various platforms.".Dec 6 2021, 3:08 PM
kstoimenov added a reverting change: rGf4606d2b70e4: Revert "[ASan] Added asan_shadow_defines.h, which contatins shadow offset for….Dec 6 2021, 3:14 PM
vitalybuka reopened this revision.EditedDec 6 2021, 3:35 PM

it's not the reason, but cmake file needs to be updated

This revision is now accepted and ready to land.Dec 6 2021, 3:35 PM
kstoimenov removed a child revision: D114558: [ASan] Shared optimized callbacks implementation..Dec 8 2021, 7:39 AM
kstoimenov abandoned this revision.Dec 8 2021, 10:45 AM

Revision Contents

PathSize
compiler-rt/
lib/
asan/
207 lines
195 lines

Diff 392171

compiler-rt/lib/asan/asan_mapping.h

//===-- asan_mapping.h ------------------------------------------*- C++ -*-===// //===-- asan_mapping.h ------------------------------------------*- C++ -*-===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// This file is a part of AddressSanitizer, an address sanity checker. // This file is a part of AddressSanitizer, an address sanity checker.
// //
// Defines ASan memory mapping. // Defines ASan memory mapping.
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef ASAN_MAPPING_H #ifndef ASAN_MAPPING_H
#define ASAN_MAPPING_H #define ASAN_MAPPING_H
#include "asan_internal.h" #include "asan_internal.h"
#include "asan_shadow_defines.h"
// The full explanation of the memory mapping could be found here:
// https://github.com/google/sanitizers/wiki/AddressSanitizerAlgorithm
//
// Typical shadow mapping on Linux/x86_64 with SHADOW_OFFSET == 0x00007fff8000:
// || `[0x10007fff8000, 0x7fffffffffff]` || HighMem ||
// || `[0x02008fff7000, 0x10007fff7fff]` || HighShadow ||
// || `[0x00008fff7000, 0x02008fff6fff]` || ShadowGap ||
// || `[0x00007fff8000, 0x00008fff6fff]` || LowShadow ||
// || `[0x000000000000, 0x00007fff7fff]` || LowMem ||
//
// When SHADOW_OFFSET is zero (-pie):
// || `[0x100000000000, 0x7fffffffffff]` || HighMem ||
// || `[0x020000000000, 0x0fffffffffff]` || HighShadow ||
// || `[0x000000040000, 0x01ffffffffff]` || ShadowGap ||
//
// Special case when something is already mapped between
// 0x003000000000 and 0x005000000000 (e.g. when prelink is installed):
// || `[0x10007fff8000, 0x7fffffffffff]` || HighMem ||
// || `[0x02008fff7000, 0x10007fff7fff]` || HighShadow ||
// || `[0x005000000000, 0x02008fff6fff]` || ShadowGap3 ||
// || `[0x003000000000, 0x004fffffffff]` || MidMem ||
// || `[0x000a7fff8000, 0x002fffffffff]` || ShadowGap2 ||
// || `[0x00067fff8000, 0x000a7fff7fff]` || MidShadow ||
// || `[0x00008fff7000, 0x00067fff7fff]` || ShadowGap ||
// || `[0x00007fff8000, 0x00008fff6fff]` || LowShadow ||
// || `[0x000000000000, 0x00007fff7fff]` || LowMem ||
//
// Default Linux/i386 mapping on x86_64 machine:
// || `[0x40000000, 0xffffffff]` || HighMem ||
// || `[0x28000000, 0x3fffffff]` || HighShadow ||
// || `[0x24000000, 0x27ffffff]` || ShadowGap ||
// || `[0x20000000, 0x23ffffff]` || LowShadow ||
// || `[0x00000000, 0x1fffffff]` || LowMem ||
//
// Default Linux/i386 mapping on i386 machine
// (addresses starting with 0xc0000000 are reserved
// for kernel and thus not sanitized):
// || `[0x38000000, 0xbfffffff]` || HighMem ||
// || `[0x27000000, 0x37ffffff]` || HighShadow ||
// || `[0x24000000, 0x26ffffff]` || ShadowGap ||
// || `[0x20000000, 0x23ffffff]` || LowShadow ||
// || `[0x00000000, 0x1fffffff]` || LowMem ||
//
// Default Linux/MIPS32 mapping:
// || `[0x2aaa0000, 0xffffffff]` || HighMem ||
// || `[0x0fff4000, 0x2aa9ffff]` || HighShadow ||
// || `[0x0bff4000, 0x0fff3fff]` || ShadowGap ||
// || `[0x0aaa0000, 0x0bff3fff]` || LowShadow ||
// || `[0x00000000, 0x0aa9ffff]` || LowMem ||
//
// Default Linux/MIPS64 mapping:
// || `[0x4000000000, 0xffffffffff]` || HighMem ||
// || `[0x2800000000, 0x3fffffffff]` || HighShadow ||
// || `[0x2400000000, 0x27ffffffff]` || ShadowGap ||
// || `[0x2000000000, 0x23ffffffff]` || LowShadow ||
// || `[0x0000000000, 0x1fffffffff]` || LowMem ||
//
// Default Linux/RISCV64 Sv39 mapping:
// || `[0x1555550000, 0x3fffffffff]` || HighMem ||
// || `[0x0fffffa000, 0x1555555fff]` || HighShadow ||
// || `[0x0effffa000, 0x0fffff9fff]` || ShadowGap ||
// || `[0x0d55550000, 0x0effff9fff]` || LowShadow ||
// || `[0x0000000000, 0x0d5554ffff]` || LowMem ||
//
// Default Linux/AArch64 (39-bit VMA) mapping:
// || `[0x2000000000, 0x7fffffffff]` || highmem ||
// || `[0x1400000000, 0x1fffffffff]` || highshadow ||
// || `[0x1200000000, 0x13ffffffff]` || shadowgap ||
// || `[0x1000000000, 0x11ffffffff]` || lowshadow ||
// || `[0x0000000000, 0x0fffffffff]` || lowmem ||
//
// Default Linux/AArch64 (42-bit VMA) mapping:
// || `[0x10000000000, 0x3ffffffffff]` || highmem ||
// || `[0x0a000000000, 0x0ffffffffff]` || highshadow ||
// || `[0x09000000000, 0x09fffffffff]` || shadowgap ||
// || `[0x08000000000, 0x08fffffffff]` || lowshadow ||
// || `[0x00000000000, 0x07fffffffff]` || lowmem ||
//
// Default Linux/S390 mapping:
// || `[0x30000000, 0x7fffffff]` || HighMem ||
// || `[0x26000000, 0x2fffffff]` || HighShadow ||
// || `[0x24000000, 0x25ffffff]` || ShadowGap ||
// || `[0x20000000, 0x23ffffff]` || LowShadow ||
// || `[0x00000000, 0x1fffffff]` || LowMem ||
//
// Default Linux/SystemZ mapping:
// || `[0x14000000000000, 0x1fffffffffffff]` || HighMem ||
// || `[0x12800000000000, 0x13ffffffffffff]` || HighShadow ||
// || `[0x12000000000000, 0x127fffffffffff]` || ShadowGap ||
// || `[0x10000000000000, 0x11ffffffffffff]` || LowShadow ||
// || `[0x00000000000000, 0x0fffffffffffff]` || LowMem ||
//
// Default Linux/SPARC64 (52-bit VMA) mapping:
// || `[0x8000000000000, 0xfffffffffffff]` || HighMem ||
// || `[0x1080000000000, 0x207ffffffffff]` || HighShadow ||
// || `[0x0090000000000, 0x107ffffffffff]` || ShadowGap ||
// || `[0x0080000000000, 0x008ffffffffff]` || LowShadow ||
// || `[0x0000000000000, 0x007ffffffffff]` || LowMem ||
//
// Shadow mapping on FreeBSD/x86-64 with SHADOW_OFFSET == 0x400000000000:
// || `[0x500000000000, 0x7fffffffffff]` || HighMem ||
// || `[0x4a0000000000, 0x4fffffffffff]` || HighShadow ||
// || `[0x480000000000, 0x49ffffffffff]` || ShadowGap ||
// || `[0x400000000000, 0x47ffffffffff]` || LowShadow ||
// || `[0x000000000000, 0x3fffffffffff]` || LowMem ||
//
// Shadow mapping on FreeBSD/i386 with SHADOW_OFFSET == 0x40000000:
// || `[0x60000000, 0xffffffff]` || HighMem ||
// || `[0x4c000000, 0x5fffffff]` || HighShadow ||
// || `[0x48000000, 0x4bffffff]` || ShadowGap ||
// || `[0x40000000, 0x47ffffff]` || LowShadow ||
// || `[0x00000000, 0x3fffffff]` || LowMem ||
//
// Shadow mapping on NetBSD/x86-64 with SHADOW_OFFSET == 0x400000000000:
// || `[0x4feffffffe01, 0x7f7ffffff000]` || HighMem ||
// || `[0x49fdffffffc0, 0x4feffffffe00]` || HighShadow ||
// || `[0x480000000000, 0x49fdffffffbf]` || ShadowGap ||
// || `[0x400000000000, 0x47ffffffffff]` || LowShadow ||
// || `[0x000000000000, 0x3fffffffffff]` || LowMem ||
//
// Shadow mapping on NetBSD/i386 with SHADOW_OFFSET == 0x40000000:
// || `[0x60000000, 0xfffff000]` || HighMem ||
// || `[0x4c000000, 0x5fffffff]` || HighShadow ||
// || `[0x48000000, 0x4bffffff]` || ShadowGap ||
// || `[0x40000000, 0x47ffffff]` || LowShadow ||
// || `[0x00000000, 0x3fffffff]` || LowMem ||
//
// Default Windows/i386 mapping:
// (the exact location of HighShadow/HighMem may vary depending
// on WoW64, /LARGEADDRESSAWARE, etc).
// || `[0x50000000, 0xffffffff]` || HighMem ||
// || `[0x3a000000, 0x4fffffff]` || HighShadow ||
// || `[0x36000000, 0x39ffffff]` || ShadowGap ||
// || `[0x30000000, 0x35ffffff]` || LowShadow ||
// || `[0x00000000, 0x2fffffff]` || LowMem ||
#if defined(ASAN_SHADOW_SCALE) #if defined(ASAN_SHADOW_SCALE)
static const u64 kDefaultShadowScale = ASAN_SHADOW_SCALE; static const u64 kDefaultShadowScale = ASAN_SHADOW_SCALE;
#else #else
static const u64 kDefaultShadowScale = 3; static const u64 kDefaultShadowScale = 3;
#endif #endif
static const u64 kDefaultShadowSentinel = ~(uptr)0;
static const u64 kDefaultShadowOffset32 = 1ULL << 29; // 0x20000000
static const u64 kDefaultShadowOffset64 = 1ULL << 44; // 0x100000000000
static const u64 kDefaultShort64bitShadowOffset =
0x7FFFFFFF & (~0xFFFULL << kDefaultShadowScale); // < 2G.
static const u64 kAArch64_ShadowOffset64 = 1ULL << 36; // 0x1000000000
static const u64 kRiscv64_ShadowOffset64 = 0xd55550000;
static const u64 kMIPS32_ShadowOffset32 = 0x0aaa0000;
static const u64 kMIPS64_ShadowOffset64 = 1ULL << 37; // 0x2000000000
static const u64 kPPC64_ShadowOffset64 = 1ULL << 44; // 0x100000000000
static const u64 kSystemZ_ShadowOffset64 = 1ULL << 52; // 0x10000000000000
static const u64 kSPARC64_ShadowOffset64 = 1ULL << 43; // 0x80000000000
static const u64 kFreeBSD_ShadowOffset32 = 1ULL << 30; // 0x40000000
static const u64 kFreeBSD_ShadowOffset64 = 1ULL << 46; // 0x400000000000
static const u64 kNetBSD_ShadowOffset32 = 1ULL << 30; // 0x40000000
static const u64 kNetBSD_ShadowOffset64 = 1ULL << 46; // 0x400000000000
static const u64 kWindowsShadowOffset32 = 3ULL << 28; // 0x30000000
vitalybukaUnsubmitted
Done
ReplyInline Actions

constexpr?

vitalybuka: constexpr?
kstoimenovAuthorUnsubmitted
Done
ReplyInline Actions

I prefer to update the whole file in a separate patch.

kstoimenov: I prefer to update the whole file in a separate patch.
#define SHADOW_SCALE kDefaultShadowScale static const u64 kDefaultShadowSentinel = ~(uptr)0;
#if SANITIZER_FUCHSIA #if defined(SHADOW_OFFSET_CONST)
# define SHADOW_OFFSET (0) static const u64 kConstShadowOffset = SHADOW_OFFSET_CONST;
#elif SANITIZER_WORDSIZE == 32 # define SHADOW_OFFSET kConstShadowOffset
# if SANITIZER_ANDROID
# define SHADOW_OFFSET __asan_shadow_memory_dynamic_address
# elif defined(__mips__)
# define SHADOW_OFFSET kMIPS32_ShadowOffset32
# elif SANITIZER_FREEBSD
# define SHADOW_OFFSET kFreeBSD_ShadowOffset32
# elif SANITIZER_NETBSD
# define SHADOW_OFFSET kNetBSD_ShadowOffset32
# elif SANITIZER_WINDOWS
# define SHADOW_OFFSET kWindowsShadowOffset32
# elif SANITIZER_IOS
# define SHADOW_OFFSET __asan_shadow_memory_dynamic_address
# else #else
# define SHADOW_OFFSET kDefaultShadowOffset32
# endif
#else
# if SANITIZER_IOS
# define SHADOW_OFFSET __asan_shadow_memory_dynamic_address
# elif SANITIZER_MAC && defined(__aarch64__)
# define SHADOW_OFFSET __asan_shadow_memory_dynamic_address
# elif SANITIZER_RISCV64
# define SHADOW_OFFSET kRiscv64_ShadowOffset64
# elif defined(__aarch64__)
# define SHADOW_OFFSET kAArch64_ShadowOffset64
# elif defined(__powerpc64__)
# define SHADOW_OFFSET kPPC64_ShadowOffset64
# elif defined(__s390x__)
# define SHADOW_OFFSET kSystemZ_ShadowOffset64
# elif SANITIZER_FREEBSD
# define SHADOW_OFFSET kFreeBSD_ShadowOffset64
# elif SANITIZER_NETBSD
# define SHADOW_OFFSET kNetBSD_ShadowOffset64
# elif SANITIZER_MAC
# define SHADOW_OFFSET kDefaultShadowOffset64
# elif defined(__mips64)
# define SHADOW_OFFSET kMIPS64_ShadowOffset64
# elif defined(__sparc__)
# define SHADOW_OFFSET kSPARC64_ShadowOffset64
# elif SANITIZER_WINDOWS64
# define SHADOW_OFFSET __asan_shadow_memory_dynamic_address # define SHADOW_OFFSET __asan_shadow_memory_dynamic_address
# else
# define SHADOW_OFFSET kDefaultShort64bitShadowOffset
# endif
#endif #endif
#define SHADOW_SCALE kDefaultShadowScale
vitalybukaUnsubmitted
Done
ReplyInline Actions

can you do just
if SHADOW_OFFSET_CONST
define SHADOW_OFFSET kConstShadowOffset
esle
define SHADOW_OFFSET __asan_shadow_memory_dynamic_address

vitalybuka: can you do just if SHADOW_OFFSET_CONST define SHADOW_OFFSET kConstShadowOffset esle define…
kstoimenovAuthorUnsubmitted
Done
ReplyInline Actions

I like that idea.

kstoimenov: I like that idea.
#if SANITIZER_ANDROID && defined(__arm__) #if SANITIZER_ANDROID && defined(__arm__)
# define ASAN_PREMAP_SHADOW 1 # define ASAN_PREMAP_SHADOW 1
#else #else
# define ASAN_PREMAP_SHADOW 0 # define ASAN_PREMAP_SHADOW 0
#endif #endif
#define SHADOW_GRANULARITY (1ULL << SHADOW_SCALE) #define SHADOW_GRANULARITY (1ULL << SHADOW_SCALE)
▲ Show 20 Lines • Show All 159 Lines • Show Last 20 Lines

compiler-rt/lib/asan/asan_shadow_defines.h

  • This file was added.
//===-- asan_shadow_defines.h -----------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
//
// This file is a part of AddressSanitizer, an address sanity checker.
//
// Defines ASan memory mapping used by assembly portion.
//===----------------------------------------------------------------------===//
#include "sanitizer_common/sanitizer_platform.h"
// The full explanation of the memory mapping could be found here:
// https://github.com/google/sanitizers/wiki/AddressSanitizerAlgorithm
//
// Typical shadow mapping on Linux/x86_64 with SHADOW_OFFSET == 0x00007fff8000:
// || `[0x10007fff8000, 0x7fffffffffff]` || HighMem ||
// || `[0x02008fff7000, 0x10007fff7fff]` || HighShadow ||
// || `[0x00008fff7000, 0x02008fff6fff]` || ShadowGap ||
// || `[0x00007fff8000, 0x00008fff6fff]` || LowShadow ||
// || `[0x000000000000, 0x00007fff7fff]` || LowMem ||
//
// When SHADOW_OFFSET is zero (-pie):
// || `[0x100000000000, 0x7fffffffffff]` || HighMem ||
// || `[0x020000000000, 0x0fffffffffff]` || HighShadow ||
// || `[0x000000040000, 0x01ffffffffff]` || ShadowGap ||
//
// Special case when something is already mapped between
// 0x003000000000 and 0x005000000000 (e.g. when prelink is installed):
// || `[0x10007fff8000, 0x7fffffffffff]` || HighMem ||
// || `[0x02008fff7000, 0x10007fff7fff]` || HighShadow ||
// || `[0x005000000000, 0x02008fff6fff]` || ShadowGap3 ||
// || `[0x003000000000, 0x004fffffffff]` || MidMem ||
// || `[0x000a7fff8000, 0x002fffffffff]` || ShadowGap2 ||
// || `[0x00067fff8000, 0x000a7fff7fff]` || MidShadow ||
// || `[0x00008fff7000, 0x00067fff7fff]` || ShadowGap ||
// || `[0x00007fff8000, 0x00008fff6fff]` || LowShadow ||
// || `[0x000000000000, 0x00007fff7fff]` || LowMem ||
//
// Default Linux/i386 mapping on x86_64 machine:
// || `[0x40000000, 0xffffffff]` || HighMem ||
// || `[0x28000000, 0x3fffffff]` || HighShadow ||
// || `[0x24000000, 0x27ffffff]` || ShadowGap ||
// || `[0x20000000, 0x23ffffff]` || LowShadow ||
// || `[0x00000000, 0x1fffffff]` || LowMem ||
//
// Default Linux/i386 mapping on i386 machine
// (addresses starting with 0xc0000000 are reserved
// for kernel and thus not sanitized):
// || `[0x38000000, 0xbfffffff]` || HighMem ||
// || `[0x27000000, 0x37ffffff]` || HighShadow ||
// || `[0x24000000, 0x26ffffff]` || ShadowGap ||
// || `[0x20000000, 0x23ffffff]` || LowShadow ||
// || `[0x00000000, 0x1fffffff]` || LowMem ||
//
// Default Linux/MIPS32 mapping:
// || `[0x2aaa0000, 0xffffffff]` || HighMem ||
// || `[0x0fff4000, 0x2aa9ffff]` || HighShadow ||
// || `[0x0bff4000, 0x0fff3fff]` || ShadowGap ||
// || `[0x0aaa0000, 0x0bff3fff]` || LowShadow ||
// || `[0x00000000, 0x0aa9ffff]` || LowMem ||
//
// Default Linux/MIPS64 mapping:
// || `[0x4000000000, 0xffffffffff]` || HighMem ||
// || `[0x2800000000, 0x3fffffffff]` || HighShadow ||
// || `[0x2400000000, 0x27ffffffff]` || ShadowGap ||
// || `[0x2000000000, 0x23ffffffff]` || LowShadow ||
// || `[0x0000000000, 0x1fffffffff]` || LowMem ||
//
// Default Linux/RISCV64 Sv39 mapping:
// || `[0x1555550000, 0x3fffffffff]` || HighMem ||
// || `[0x0fffffa000, 0x1555555fff]` || HighShadow ||
// || `[0x0effffa000, 0x0fffff9fff]` || ShadowGap ||
// || `[0x0d55550000, 0x0effff9fff]` || LowShadow ||
// || `[0x0000000000, 0x0d5554ffff]` || LowMem ||
//
// Default Linux/AArch64 (39-bit VMA) mapping:
// || `[0x2000000000, 0x7fffffffff]` || highmem ||
// || `[0x1400000000, 0x1fffffffff]` || highshadow ||
// || `[0x1200000000, 0x13ffffffff]` || shadowgap ||
// || `[0x1000000000, 0x11ffffffff]` || lowshadow ||
// || `[0x0000000000, 0x0fffffffff]` || lowmem ||
//
// Default Linux/AArch64 (42-bit VMA) mapping:
// || `[0x10000000000, 0x3ffffffffff]` || highmem ||
// || `[0x0a000000000, 0x0ffffffffff]` || highshadow ||
// || `[0x09000000000, 0x09fffffffff]` || shadowgap ||
// || `[0x08000000000, 0x08fffffffff]` || lowshadow ||
// || `[0x00000000000, 0x07fffffffff]` || lowmem ||
//
// Default Linux/S390 mapping:
// || `[0x30000000, 0x7fffffff]` || HighMem ||
// || `[0x26000000, 0x2fffffff]` || HighShadow ||
// || `[0x24000000, 0x25ffffff]` || ShadowGap ||
// || `[0x20000000, 0x23ffffff]` || LowShadow ||
// || `[0x00000000, 0x1fffffff]` || LowMem ||
//
// Default Linux/SystemZ mapping:
// || `[0x14000000000000, 0x1fffffffffffff]` || HighMem ||
// || `[0x12800000000000, 0x13ffffffffffff]` || HighShadow ||
// || `[0x12000000000000, 0x127fffffffffff]` || ShadowGap ||
// || `[0x10000000000000, 0x11ffffffffffff]` || LowShadow ||
// || `[0x00000000000000, 0x0fffffffffffff]` || LowMem ||
//
// Default Linux/SPARC64 (52-bit VMA) mapping:
// || `[0x8000000000000, 0xfffffffffffff]` || HighMem ||
// || `[0x1080000000000, 0x207ffffffffff]` || HighShadow ||
// || `[0x0090000000000, 0x107ffffffffff]` || ShadowGap ||
// || `[0x0080000000000, 0x008ffffffffff]` || LowShadow ||
// || `[0x0000000000000, 0x007ffffffffff]` || LowMem ||
//
// Shadow mapping on FreeBSD/x86-64 with SHADOW_OFFSET == 0x400000000000:
// || `[0x500000000000, 0x7fffffffffff]` || HighMem ||
// || `[0x4a0000000000, 0x4fffffffffff]` || HighShadow ||
// || `[0x480000000000, 0x49ffffffffff]` || ShadowGap ||
// || `[0x400000000000, 0x47ffffffffff]` || LowShadow ||
// || `[0x000000000000, 0x3fffffffffff]` || LowMem ||
//
// Shadow mapping on FreeBSD/i386 with SHADOW_OFFSET == 0x40000000:
// || `[0x60000000, 0xffffffff]` || HighMem ||
// || `[0x4c000000, 0x5fffffff]` || HighShadow ||
// || `[0x48000000, 0x4bffffff]` || ShadowGap ||
// || `[0x40000000, 0x47ffffff]` || LowShadow ||
// || `[0x00000000, 0x3fffffff]` || LowMem ||
//
// Shadow mapping on NetBSD/x86-64 with SHADOW_OFFSET == 0x400000000000:
// || `[0x4feffffffe01, 0x7f7ffffff000]` || HighMem ||
// || `[0x49fdffffffc0, 0x4feffffffe00]` || HighShadow ||
// || `[0x480000000000, 0x49fdffffffbf]` || ShadowGap ||
// || `[0x400000000000, 0x47ffffffffff]` || LowShadow ||
// || `[0x000000000000, 0x3fffffffffff]` || LowMem ||
//
// Shadow mapping on NetBSD/i386 with SHADOW_OFFSET == 0x40000000:
// || `[0x60000000, 0xfffff000]` || HighMem ||
// || `[0x4c000000, 0x5fffffff]` || HighShadow ||
// || `[0x48000000, 0x4bffffff]` || ShadowGap ||
// || `[0x40000000, 0x47ffffff]` || LowShadow ||
// || `[0x00000000, 0x3fffffff]` || LowMem ||
//
// Default Windows/i386 mapping:
// (the exact location of HighShadow/HighMem may vary depending
// on WoW64, /LARGEADDRESSAWARE, etc).
// || `[0x50000000, 0xffffffff]` || HighMem ||
// || `[0x3a000000, 0x4fffffff]` || HighShadow ||
// || `[0x36000000, 0x39ffffff]` || ShadowGap ||
// || `[0x30000000, 0x35ffffff]` || LowShadow ||
// || `[0x00000000, 0x2fffffff]` || LowMem ||
#if !defined(SANITIZER_WORDSIZE)
# error "SANITIZER_WORDSIZE must be defined."
#endif
#if SANITIZER_FUCHSIA
# define SHADOW_OFFSET_CONST 0x0
#elif SANITIZER_WORDSIZE == 32
# if defined(__mips__)
# define SHADOW_OFFSET_CONST 0xaaa0000
# elif SANITIZER_FREEBSD
vitalybukaUnsubmitted
Done
ReplyInline Actions

0x0aaa0000 for better alignment

vitalybuka: 0x0aaa0000 for better alignment
# define SHADOW_OFFSET_CONST 0x40000000
# elif SANITIZER_NETBSD
# define SHADOW_OFFSET_CONST 0x40000000
# elif SANITIZER_WINDOWS
# define SHADOW_OFFSET_CONST 0x30000000
# else
# define SHADOW_OFFSET_CONST 0x20000000
vitalybukaUnsubmitted
Done
ReplyInline Actions

SANITIZER_IOS 32bit

  1. define SHADOW_OFFSET __asan_shadow_memory_dynamic_address
vitalybuka: SANITIZER_IOS 32bit # define SHADOW_OFFSET __asan_shadow_memory_dynamic_address
kstoimenovAuthorUnsubmitted
Done
ReplyInline Actions

Removed.

kstoimenov: Removed.
# endif
#elif SANITIZER_WORDSIZE == 64
# if SANITIZER_RISCV64
# define SHADOW_OFFSET_CONST 0x0d55550000
# elif defined(__aarch64__)
# define SHADOW_OFFSET_CONST 0x1000000000
# elif defined(__powerpc64__)
vitalybukaUnsubmitted
Done
ReplyInline Actions

kRiscv64_ShadowOffset64 = 0xd55550000;

vitalybuka: kRiscv64_ShadowOffset64 = 0xd55550000;
vitalybukaUnsubmitted
Done
ReplyInline Actions

it would be nice if you align all these to 8bytes with leading 0s as well

vitalybuka: it would be nice if you align all these to 8bytes with leading 0s as well
vitalybukaUnsubmitted
Not Done
ReplyInline Actions

it would be nice if you align all these to 8bytes with leading 0s as well

You call, but I expected 64bit values like this: 0x0d55550000 -> 0x0000000d55550000

vitalybuka: > it would be nice if you align all these to 8bytes with leading 0s as well You call, but I…
# define SHADOW_OFFSET_CONST 0x100000000000
vitalybukaUnsubmitted
Not Done
ReplyInline Actions

SANITIZER_MAC && defined(aarch64) should be __asan_shadow_memory_dynamic_address

also SANITIZER_WINDOWS64 __asan_shadow_memory_dynamic_address

vitalybuka: SANITIZER_MAC && defined(__aarch64__) should be __asan_shadow_memory_dynamic_address also…
vitalybukaUnsubmitted
Not Done
ReplyInline Actions

This one is not done?

vitalybuka: This one is not done?
kstoimenovAuthorUnsubmitted
Done
ReplyInline Actions

Not sure what you mean by that.

kstoimenov: Not sure what you mean by that.
vitalybukaUnsubmitted
Not Done
ReplyInline Actions

SANITIZER_MAC && defined(aarch64) had a different constant

vitalybuka: SANITIZER_MAC && defined(__aarch64__) had a different constant
# elif defined(__s390x__)
# define SHADOW_OFFSET_CONST 0x10000000000000
# elif SANITIZER_FREEBSD
# define SHADOW_OFFSET_CONST 0x400000000000
# elif SANITIZER_NETBSD
# define SHADOW_OFFSET_CONST 0x400000000000
# elif SANITIZER_MAC
# define SHADOW_OFFSET_CONST 0x100000000000
# elif defined(__mips64)
# define SHADOW_OFFSET_CONST 0x02000000000
# elif defined(__sparc__)
vitalybukaUnsubmitted
Done
ReplyInline Actions

this one was u64 kDefaultShadowOffset64 = 1ULL << 44
or 0x100000000000

vitalybuka: this one was u64 kDefaultShadowOffset64 = 1ULL << 44 or 0x100000000000
kstoimenovAuthorUnsubmitted
Done
ReplyInline Actions

I added an error message for this.

kstoimenov: I added an error message for this.
vitalybukaUnsubmitted
Not Done
ReplyInline Actions

this one was u64 kDefaultShadowOffset64 = 1ULL << 44

I added an error message for this.

I see you fixed the constant. What does this reply mean here?

vitalybuka: >> this one was u64 kDefaultShadowOffset64 = 1ULL << 44 > I added an error message for this. I…
kstoimenovAuthorUnsubmitted
Done
ReplyInline Actions

I added this error:

  1. error "Only ASAN_SHADOW_SCALE = 3 is supported."
kstoimenov: I added this error: # error "Only ASAN_SHADOW_SCALE = 3 is supported."
# define SHADOW_OFFSET_CONST 0x80000000000
# else
# if defined(ASAN_SHADOW_SCALE) && (ASAN_SHADOW_SCALE != 3)
vitalybukaUnsubmitted
Done
ReplyInline Actions

we lost

#  elif defined(__sparc__)
#    define SHADOW_OFFSET_CONST 0x80000000000
vitalybuka: we lost ``` # elif defined(__sparc__) # define SHADOW_OFFSET_CONST 0x80000000000 ```
# error "Only ASAN_SHADOW_SCALE = 3 is supported."
vitalybukaUnsubmitted
Done
ReplyInline Actions

It was 0x7FFFFFFF & (~0xFFFULL << kDefaultShadowScale);
you need to use
#if defined(ASAN_SHADOW_SCALE) here

vitalybuka: It was 0x7FFFFFFF & (~0xFFFULL << kDefaultShadowScale); you need to use #if defined…
vitalybukaUnsubmitted
Done
ReplyInline Actions

or we can remove COMPILER_RT_ASAN_SHADOW_SCALE and ASAN_SHADOW_SCALE, it's should be unused after related code was removed

vitalybuka: or we can remove COMPILER_RT_ASAN_SHADOW_SCALE and ASAN_SHADOW_SCALE, it's should be unused…
kstoimenovAuthorUnsubmitted
Done
ReplyInline Actions

Removing ASAN_SHADOW_SCALE is another clean up patch I think.

kstoimenov: Removing ASAN_SHADOW_SCALE is another clean up patch I think.
kstoimenovAuthorUnsubmitted
Done
ReplyInline Actions

I added an error message if ASAN_SHADOW_SCALE != 3.

kstoimenov: I added an error message if ASAN_SHADOW_SCALE != 3.
# endif
# define SHADOW_OFFSET_CONST 0x7fff8000
# endif
#endif