[libc++][NFC] Disable clang-tidy checks

[philnik]

Summary

Disable clang-tidy checks as discussed in D114915

[cjdb]

Why is llvm-else-after-return disabled? That's a pretty important readability improvement. What about llvm-header-guard?

[ldionne]

In D114985#3167911, @cjdb wrote:

Why is llvm-else-after-return disabled? That's a pretty important readability improvement. What about llvm-header-guard?

IIUC llvm-else-after-return is the thing that tries to remove any else after an if that contains a return? IMO that's not a readability improvement at all, at least not in the places where it modified the code in D114915.

[philnik]

You are right, llvm-else-after-return is the check for that.

[cjdb]

In D114985#3167951, @ldionne wrote:

In D114985#3167911, @cjdb wrote:

Why is llvm-else-after-return disabled? That's a pretty important readability improvement. What about llvm-header-guard?

IIUC llvm-else-after-return is the thing that tries to remove any else after an if that contains a return? IMO that's not a readability improvement at all, at least not in the places where it modified the code in D114915.

I found a lot of the changes to improve readability, but the __libcpp_is_constant_evaluated ones were dubious and I can see why we should disable it for the time being.

libcxx/.clang-tidy

 InheritParentConfig: true
-Checks: '-readability-identifier-naming'
+Checks: '-readability-identifier-naming,-llvm-header-guard,-llvm-include-order,-misc-unconventional-assign-operator,-llvm-else-after-return'