Page MenuHomePhabricator

[mlir][linalg] Pad independent of application order (NFC).
ClosedPublic

Authored by gysit on Dec 1 2021, 12:18 AM.

Details

Summary

This revision makes the padding pattern independent of the application order. It addresses the concern that we cannot rely on the execution order of the greedy rewriter (https://reviews.llvm.org/D114689). Instead, the pattern is updated to apply repeatedly till all operations are padded.

Diff Detail

Event Timeline

gysit created this revision.Dec 1 2021, 12:18 AM
gysit requested review of this revision.Dec 1 2021, 12:18 AM

@mehdi_amini this patch makes the padding robust with respect to the pattern application order and should address the concern you raised in https://reviews.llvm.org/D114689.

mehdi_amini accepted this revision.Dec 3 2021, 9:24 PM

Great, thanks!

This revision is now accepted and ready to land.Dec 3 2021, 9:24 PM
This revision was automatically updated to reflect the committed changes.