This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][clang] Fix __builtin_nontemporal_store() failure on AMDGPU
ClosedPublic

Authored by skc7 on Nov 30 2021, 11:27 PM.

Details

Summary

__builtin_nontemporal_store() fails on AMDGPU. This is due to mismatch in address space while creating bitcast. This change matches addrspace of poiter type to src addrSpace in EmitNontemporalStore() in clang codegen.

Diff Detail

Event Timeline

skc7 created this revision.Nov 30 2021, 11:27 PM
skc7 requested review of this revision.Nov 30 2021, 11:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2021, 11:27 PM
yaxunl added inline comments.Dec 1 2021, 7:15 AM
clang/test/CodeGenOpenCL/amdgcn-non-temporal-store.cl
9

pls add newline

skc7 updated this revision to Diff 391023.Dec 1 2021, 7:47 AM

added new life at eof amdgcn-non-temporal-store.cl

yaxunl accepted this revision.Dec 1 2021, 1:18 PM

LGTM. Thanks.

This revision is now accepted and ready to land.Dec 1 2021, 1:18 PM
skc7 set the repository for this revision to rG LLVM Github Monorepo.Dec 1 2021, 8:25 PM
This revision was landed with ongoing or failed builds.Dec 1 2021, 9:55 PM
This revision was automatically updated to reflect the committed changes.