This is an archive of the discontinued LLVM Phabricator instance.

Remove unneeded printString methods
ClosedPublic

Authored by Jaysonyan on Nov 29 2021, 2:05 PM.

Details

Summary

As mentioned in D114223#inline-1095135 both std::string and char * implicitly convert to StringRef so these overloaded methods are not needed.

Diff Detail

Event Timeline

Jaysonyan created this revision.Nov 29 2021, 2:05 PM
Jaysonyan requested review of this revision.Nov 29 2021, 2:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2021, 2:05 PM
jhenderson accepted this revision.Nov 30 2021, 12:25 AM

LGTM, assuming nothing fell over in a local build.

This revision is now accepted and ready to land.Nov 30 2021, 12:25 AM
This revision was landed with ongoing or failed builds.Dec 10 2021, 10:58 AM
This revision was automatically updated to reflect the committed changes.