This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][doc] Document recent spaceship projects progress
ClosedPublic

Authored by mumbleskates on Nov 28 2021, 6:28 PM.

Details

Summary

Update a couple authors, differentials, and completed projects for operator<=> implementation

Diff Detail

Event Timeline

mumbleskates created this revision.Nov 28 2021, 6:28 PM
mumbleskates requested review of this revision.Nov 28 2021, 6:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2021, 6:28 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
  • add link to coroutine differential
  • move [charconv.syn] to Formatting
mumbleskates edited reviewers, added: Quuxplusone; removed: ldionne.Nov 28 2021, 6:46 PM
ldionne accepted this revision.Nov 29 2021, 5:22 AM
This revision is now accepted and ready to land.Nov 29 2021, 5:22 AM
Mordante requested changes to this revision.Nov 29 2021, 9:31 AM

In general LGTM, but the <charconv> changes are wrong.

libcxx/docs/Status/FormatPaper.csv
4 ↗(On Diff #390234)

As mention on Discord, this is wrong. This change belongs to P1614.

This revision now requires changes to proceed.Nov 29 2021, 9:31 AM
  • Revert "move [charconv.syn] to Formatting"
  • add reference to P1614 in the spaceship RST
  • correct section name for move_iterator
Mordante accepted this revision.Nov 30 2021, 11:59 AM

LGTM, one minor nit remaining.

libcxx/docs/Status/Spaceship.rst
18 ↗(On Diff #390772)

I think this change isn't really required. The open list contains P2404R0 and P2249 may also end up in this list.
If you want to keep it make sure change it to P1614R2 is both the text and the link.

We recently added the revision number to our open papers list, since it can happen that a newer revision of a paper exists than the version voted into the Standard.

This revision is now accepted and ready to land.Nov 30 2021, 11:59 AM
mumbleskates marked an inline comment as done.
  • Revert "add reference to P1614 in the spaceship RST"
libcxx/docs/Status/Spaceship.rst
18 ↗(On Diff #390772)

sgtm