This is an archive of the discontinued LLVM Phabricator instance.

Differential D114615

[NFC][clang]Increase the number of driver diagnostics
ClosedPublic

Authored by stevewan on Nov 25 2021, 3:49 PM.

Details

Reviewers
erichkeane
ZarkoCA
zixuw
Commits
rG3c32c568844c: [NFC][clang]Increase the number of driver diagnostics
Summary

We're close to hitting the limited number of driver diagnostics, increase DIAG_SIZE_DRIVER to accommodate more.

Diff Detail

Event Timeline

stevewan requested review of this revision.Nov 25 2021, 3:49 PM
stevewan created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 25 2021, 3:49 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
stevewan retitled this revision from Increase the number of driver diagnostics to [NFC][clang]Increase the number of driver diagnostics.Nov 25 2021, 3:53 PM
stevewan added reviewers: erichkeane, ZarkoCA, zixuw.
Harbormaster completed remote builds in B136128: Diff 389885.Nov 25 2021, 4:39 PM
erichkeane accepted this revision.Nov 29 2021, 9:01 AM

Please ignore the clang-format suggestion.

This revision is now accepted and ready to land.Nov 29 2021, 9:01 AM
This revision was landed with ongoing or failed builds.Nov 29 2021, 11:12 AM
Closed by commit rG3c32c568844c: [NFC][clang]Increase the number of driver diagnostics (authored by stevewan). · Explain Why
This revision was automatically updated to reflect the committed changes.
stevewan added a commit: rG3c32c568844c: [NFC][clang]Increase the number of driver diagnostics.

Revision Contents

PathSize
clang/
include/
clang/
Basic/
2 lines

Diff 389885

clang/include/clang/Basic/DiagnosticIDs.h

//===--- DiagnosticIDs.h - Diagnostic IDs Handling --------------*- C++ -*-===// //===--- DiagnosticIDs.h - Diagnostic IDs Handling --------------*- C++ -*-===//
Lint: Lint
Inline Actions

clang-format suggested style edits found:

Lint: Lint: clang-format suggested style edits found:
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
/// ///
/// \file /// \file
Show All 14 Linesnamespace clang {
class SourceLocation; class SourceLocation;
// Import the diagnostic enums themselves. // Import the diagnostic enums themselves.
namespace diag { namespace diag {
enum class Group; enum class Group;
// Size of each of the diagnostic categories. // Size of each of the diagnostic categories.
enum { enum {
DIAG_SIZE_COMMON = 300, DIAG_SIZE_COMMON = 300,
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-      DIAG_SIZE_COMMON        =  300,
-      DIAG_SIZE_DRIVER        =  300,
-      DIAG_SIZE_FRONTEND      =  150,
-      DIAG_SIZE_SERIALIZATION =  120,
-      DIAG_SIZE_LEX           =  400,
-      DIAG_SIZE_PARSE         =  600,
-      DIAG_SIZE_AST           =  250,
-      DIAG_SIZE_COMMENT       =  100,
-      DIAG_SIZE_CROSSTU       =  100,
-      DIAG_SIZE_SEMA          = 4500,

14 diff lines are omitted. See full path.

Lint: Pre-merge checks: clang-format: please reformat the code ``` - DIAG_SIZE_COMMON = 300…
DIAG_SIZE_DRIVER = 250, DIAG_SIZE_DRIVER = 300,
DIAG_SIZE_FRONTEND = 150, DIAG_SIZE_FRONTEND = 150,
DIAG_SIZE_SERIALIZATION = 120, DIAG_SIZE_SERIALIZATION = 120,
DIAG_SIZE_LEX = 400, DIAG_SIZE_LEX = 400,
DIAG_SIZE_PARSE = 600, DIAG_SIZE_PARSE = 600,
DIAG_SIZE_AST = 250, DIAG_SIZE_AST = 250,
DIAG_SIZE_COMMENT = 100, DIAG_SIZE_COMMENT = 100,
DIAG_SIZE_CROSSTU = 100, DIAG_SIZE_CROSSTU = 100,
DIAG_SIZE_SEMA = 4500, DIAG_SIZE_SEMA = 4500,
▲ Show 20 Lines • Show All 314 Lines • Show Last 20 Lines