This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Rename test/python/dialects/math.py -> math_dialect.py
ClosedPublic

Authored by bondhugula on Nov 24 2021, 7:35 PM.

Details

Summary

Rename test/python/dialects/math.py -> math_dialect.py to avoid a
collision with a Python standard package of the same name. These test
scripts are run by path and are not part of a package. Python apparently
implicitly adds the containing directory to its PYTHONPATH. As such,
test scripts with common names run the risk of conflicting with global
names and resolution of an import for the latter happens to the former.

Diff Detail

Event Timeline

bondhugula created this revision.Nov 24 2021, 7:35 PM
bondhugula requested review of this revision.Nov 24 2021, 7:35 PM
stellaraccident accepted this revision.Nov 24 2021, 7:45 PM
This revision is now accepted and ready to land.Nov 24 2021, 7:45 PM
mehdi_amini accepted this revision.Nov 24 2021, 7:59 PM