Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D114494

[NFC][sanitizer] Add entry point for compression
ClosedPublic
Actions

Authored by vitalybuka on Nov 23 2021, 7:04 PM.

Details

Reviewers
morehouse
eugenis
kstoimenov
dvyukov
Commits
rG7c1d77798346: [NFC][sanitizer] Add entry point for compression
Summary

Add Compression::Test type which just pretends packing,
but does nothing useful. It's only called from test for now.

Depends on D114493.

Diff Detail

Event Timeline

vitalybuka requested review of this revision.Nov 23 2021, 7:04 PM
vitalybuka created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 23 2021, 7:04 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka edited the summary of this revision. (Show Details)Nov 23 2021, 7:10 PM
vitalybuka added reviewers: morehouse, eugenis, kstoimenov, dvyukov.
vitalybuka updated this revision to Diff 389372.Nov 23 2021, 7:10 PM

comment

Harbormaster completed remote builds in B135763: Diff 389372.Nov 23 2021, 7:28 PM
vitalybuka added a child revision: D114495: [sanitizer] Add compress_stack_depot flag.Nov 23 2021, 7:28 PM
vitalybuka updated this revision to Diff 389561.Nov 24 2021, 11:01 AM

rebase

Harbormaster completed remote builds in B135897: Diff 389561.Nov 24 2021, 12:29 PM
morehouse added inline comments.Nov 29 2021, 10:54 AM
compiler-rt/lib/sanitizer_common/sanitizer_stack_store.cpp
146
169
compiler-rt/lib/sanitizer_common/tests/sanitizer_stack_store_test.cpp
149

Don't overflow.

152

122 seems arbitrary. Maybe just check that CountPackedBlocks() decrements after loading a block.

vitalybuka updated this revision to Diff 390794.Nov 30 2021, 12:50 PM
vitalybuka marked 4 inline comments as done.

update

Harbormaster completed remote builds in B136756: Diff 390794.Nov 30 2021, 1:16 PM
vitalybuka updated this revision to Diff 390815.Nov 30 2021, 1:55 PM

update

Harbormaster completed remote builds in B136772: Diff 390815.Nov 30 2021, 2:11 PM
kstoimenov accepted this revision.Nov 30 2021, 2:50 PM
kstoimenov added inline comments.
compiler-rt/lib/sanitizer_common/sanitizer_stack_store.h
97–99

Maybe add thread annotations to those functions also?

This revision is now accepted and ready to land.Nov 30 2021, 2:50 PM
vitalybuka updated this revision to Diff 390862.Nov 30 2021, 4:54 PM

rebases

compiler-rt/lib/sanitizer_common/sanitizer_stack_store.h
97–99

now sure which apply here

This revision was landed with ongoing or failed builds.Nov 30 2021, 4:55 PM
Closed by commit rG7c1d77798346: [NFC][sanitizer] Add entry point for compression (authored by vitalybuka). · Explain Why
This revision was automatically updated to reflect the committed changes.
vitalybuka added a commit: rG7c1d77798346: [NFC][sanitizer] Add entry point for compression.
Harbormaster completed remote builds in B136804: Diff 390862.Nov 30 2021, 5:44 PM

Revision Contents
Changeset List

PathSize
compiler-rt/
lib/
sanitizer_common/
27 lines
77 lines
2 lines
tests/
54 lines

Diff 390815

View Options

compiler-rt/lib/sanitizer_common/sanitizer_stack_store.h

Loading...
View Options

compiler-rt/lib/sanitizer_common/sanitizer_stack_store.cpp

Loading...
View Options

compiler-rt/lib/sanitizer_common/sanitizer_stackdepot.cpp

Loading...
View Options

compiler-rt/lib/sanitizer_common/tests/sanitizer_stack_store_test.cpp

Loading...