This is an archive of the discontinued LLVM Phabricator instance.

[NFC][sanitizer] Add entry point for compression
ClosedPublic

Authored by vitalybuka on Nov 23 2021, 7:04 PM.

Details

Summary

Add Compression::Test type which just pretends packing,
but does nothing useful. It's only called from test for now.

Depends on D114493.

Diff Detail

Event Timeline

vitalybuka requested review of this revision.Nov 23 2021, 7:04 PM
vitalybuka created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 23 2021, 7:04 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka edited the summary of this revision. (Show Details)Nov 23 2021, 7:10 PM
morehouse added inline comments.Nov 29 2021, 10:54 AM
compiler-rt/lib/sanitizer_common/sanitizer_stack_store.cpp
146
169
compiler-rt/lib/sanitizer_common/tests/sanitizer_stack_store_test.cpp
149

Don't overflow.

152

122 seems arbitrary. Maybe just check that CountPackedBlocks() decrements after loading a block.

vitalybuka marked 4 inline comments as done.

update

kstoimenov accepted this revision.Nov 30 2021, 2:50 PM
kstoimenov added inline comments.
compiler-rt/lib/sanitizer_common/sanitizer_stack_store.h
97–99

Maybe add thread annotations to those functions also?

This revision is now accepted and ready to land.Nov 30 2021, 2:50 PM

rebases

compiler-rt/lib/sanitizer_common/sanitizer_stack_store.h
97–99

now sure which apply here

This revision was landed with ongoing or failed builds.Nov 30 2021, 4:55 PM
This revision was automatically updated to reflect the committed changes.