Page MenuHomePhabricator

[NFC][AIX]Disable precompiled module file tests on AIX
ClosedPublic

Authored by stevewan on Nov 23 2021, 2:57 PM.

Details

Summary

The PCH reader looks for __clangast section in the precompiled module file, which is not present in the file on AIX, and we don't support writing this custom section in XCOFF yet.

Diff Detail

Event Timeline

stevewan requested review of this revision.Nov 23 2021, 2:57 PM
stevewan created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 23 2021, 2:57 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
daltenty accepted this revision.Nov 24 2021, 7:56 AM

LGTM, with minor nit.

clang/test/ClangScanDeps/modules-pch-common-submodule.c
1

Let's add a comment, to let folks know what's going on with these. Something like:

// Unsupported on AIX because we don't support the requisite __clangast section in XCOFF yet.

This revision is now accepted and ready to land.Nov 24 2021, 7:56 AM
stevewan updated this revision to Diff 389535.Nov 24 2021, 10:21 AM

Explain the rationale

stevewan marked an inline comment as done.Nov 24 2021, 10:21 AM
This revision was landed with ongoing or failed builds.Nov 24 2021, 10:22 AM
This revision was automatically updated to reflect the committed changes.