This is an archive of the discontinued LLVM Phabricator instance.

tsan: disable signal_sync2.cpp test on powerpc64
ClosedPublic

Authored by dvyukov on Nov 23 2021, 2:51 AM.

Download Raw Diff

Details

Reviewers

vitalybuka
nemanjai

Commits

rGd75ed9864acb: tsan: disable signal_sync2.cpp test on powerpc64

Summary

Fails 1 out of 10 runs on powerpc bots:
https://lab.llvm.org/buildbot/#/builders/121/builds/13391

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

dvyukov created this revision.Nov 23 2021, 2:51 AM

Herald added subscribers: steven.zhang, shchenz, nemanjai. · View Herald TranscriptNov 23 2021, 2:51 AM

dvyukov requested review of this revision.Nov 23 2021, 2:51 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 23 2021, 2:51 AM

Herald added a subscriber: Restricted Project. · View Herald Transcript

Although the "one in 10" estimate seems to be a bit inflated, the test case certainly seems to be flaky so I am not opposed to disabling it. Thank you.

This revision is now accepted and ready to land.Nov 23 2021, 3:05 AM

Harbormaster completed remote builds in B135585: Diff 389140.Nov 23 2021, 5:57 AM

rephrase comment

In D114426#3148437, @nemanjai wrote:

Although the "one in 10" estimate seems to be a bit inflated, the test case certainly seems to be flaky so I am not opposed to disabling it. Thank you.

Somebody reported it to me privately and I just took that "one in 10" from that report. I rephrased the comment to:

"Fails episodically on powerpc bots:"

This revision was landed with ongoing or failed builds.Nov 23 2021, 8:58 AM

Closed by commit rGd75ed9864acb: tsan: disable signal_sync2.cpp test on powerpc64 (authored by dvyukov). · Explain Why

This revision was automatically updated to reflect the committed changes.

dvyukov added a commit: rGd75ed9864acb: tsan: disable signal_sync2.cpp test on powerpc64.

Harbormaster completed remote builds in B135649: Diff 389223.Nov 23 2021, 1:51 PM

Revision Contents

Path

Size

compiler-rt/

test/

tsan/

signal_sync2.cpp

3 lines

Diff 389140

compiler-rt/test/tsan/signal_sync2.cpp

	// RUN: %clangxx_tsan -O1 %s -o %t && %run %t 2>&1 \| FileCheck %s			// RUN: %clangxx_tsan -O1 %s -o %t && %run %t 2>&1 \| FileCheck %s
	// UNSUPPORTED: darwin			// UNSUPPORTED: darwin
				// Fails 1 out of 10 runs on powerpc bots:
				// https://lab.llvm.org/buildbot/#/builders/121/builds/13391
				// UNSUPPORTED: powerpc64, powerpc64le
	#include "test.h"			#include "test.h"
	#include <errno.h>			#include <errno.h>
	#include <signal.h>			#include <signal.h>
	#include <sys/time.h>			#include <sys/time.h>
	#include <sys/types.h>			#include <sys/types.h>

	// Test synchronization in signal handled within IgnoreSync region.			// Test synchronization in signal handled within IgnoreSync region.

	▲ Show 20 Lines • Show All 61 Lines • Show Last 20 Lines