Apparently my methodology was suboptimal, and not only did miss all the +VL tuples,
i also missed some plain tuples. I believe, this adds everything missing.
Indeed, these manual costmodels are just not okay long-term.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I repeat my self. Having the agenda in a diff is suboptimal. Maybe a document in the repo?
Comment Actions
In these patches i'm not inventing this suboptimal approach, but merely following the current standard practice, so i'm a little unsure about this sudden negativity.
There are several bugs in bugzilla about that, e.g. https://bugs.llvm.org/show_bug.cgi?id=32325 https://bugs.llvm.org/show_bug.cgi?id=35784 https://bugs.llvm.org/show_bug.cgi?id=36550
Comment Actions
LGTM - this is inline with the existing approach we've had in X86 for many years that is explained at the top of the file - maintain a 'worst case' cost for each ISA level