This is an archive of the discontinued LLVM Phabricator instance.

[flang] Remove typo that affected complex namelist input
ClosedPublic

Authored by klausler on Nov 19 2021, 4:05 PM.

Details

Summary

A recent patch to real/complex formatted input included what must
have been an editing hiccup: "++ ++p" instead of "++p". This
compiles, and it broke the consumption of the trailing ')' of a
complex value in namelist input by skipping over the character.

Diff Detail

Event Timeline

klausler created this revision.Nov 19 2021, 4:05 PM
klausler requested review of this revision.Nov 19 2021, 4:05 PM
rovka added a subscriber: rovka.Nov 21 2021, 11:40 PM

Can you add a unit test for this?

klausler updated this revision to Diff 389048.Nov 22 2021, 2:59 PM

Extend existing test to cover this case; extend comment, tune predicate.

Renaud-K accepted this revision.Nov 22 2021, 3:01 PM
This revision is now accepted and ready to land.Nov 22 2021, 3:01 PM

Can you add a unit test for this?

Extended existing test to cover it.

This revision was landed with ongoing or failed builds.Nov 22 2021, 3:07 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptNov 22 2021, 3:07 PM