Page MenuHomePhabricator

[SLP]Improve isFixedVectorShuffle and its use.
ClosedPublic

Authored by ABataev on Wed, Nov 17, 1:46 PM.

Details

Summary

Extended support for undefined source vector/extract indices/non-fixed
vector types, also no need to check for the parent of the extractelement
instructions with the constant indicies.

Diff Detail

Event Timeline

ABataev created this revision.Wed, Nov 17, 1:46 PM
ABataev requested review of this revision.Wed, Nov 17, 1:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Nov 17, 1:46 PM
RKSimon added inline comments.Thu, Nov 18, 9:20 AM
llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
4540

Can we use "isa<ExtractElementInst,UndefValue>(V)" here?

ABataev added inline comments.Thu, Nov 18, 9:25 AM
llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
4540

Sure, will do

ABataev updated this revision to Diff 388244.Thu, Nov 18, 9:46 AM

Address comments.

RKSimon accepted this revision.Tue, Nov 30, 8:29 AM

LGTM - cheers

This revision is now accepted and ready to land.Tue, Nov 30, 8:29 AM
This revision was landed with ongoing or failed builds.Tue, Nov 30, 10:25 AM
This revision was automatically updated to reflect the committed changes.