Page MenuHomePhabricator

[X86] Add tests cases for or-lea with no common bits.
ClosedPublic

Authored by OmerAviram on Wed, Nov 17, 4:50 AM.

Details

Summary

Added tests are permutations of the pattern: (X & ~M) or (Y & M).

Diff Detail

Event Timeline

OmerAviram created this revision.Wed, Nov 17, 4:50 AM
OmerAviram requested review of this revision.Wed, Nov 17, 4:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Nov 17, 4:50 AM
RKSimon added inline comments.Mon, Nov 22, 3:33 AM
llvm/test/CodeGen/X86/or-lea.ll
154

Why have you used i16? That is the one type that x86 will try very hard to promote to i32/64 for a shorter encoding and to break partial register dependencies.

OmerAviram added inline comments.Mon, Nov 22, 7:05 AM
llvm/test/CodeGen/X86/or-lea.ll
154

I see, thanks. Any suggestion for a type better suited for those tests?

RKSimon added inline comments.Mon, Nov 22, 8:51 AM
llvm/test/CodeGen/X86/or-lea.ll
154

Probably a mixture of i32 and i64 tests?

Also, please don't just number tests - try to give them descriptive names like most of these existing tests in this file.

OmerAviram marked an inline comment as done.
RKSimon accepted this revision.Wed, Nov 24, 3:40 AM

LGTM

This revision is now accepted and ready to land.Wed, Nov 24, 3:40 AM

@OmerAviram Do you have commit access?

@OmerAviram Do you have commit access?

I don't, would appreciate if you could commit on my behalf.
Thanks.

This revision was automatically updated to reflect the committed changes.