Page MenuHomePhabricator

OmerAviram (Omer Aviram)
User

Projects

User does not belong to any projects.

User Details

User Since
Mon, Nov 15, 6:53 AM (1 w, 4 d)

Recent Activity

Yesterday

OmerAviram updated the diff for D114575: [X86] Add vector test coverage for or with no common bits tests.
Thu, Nov 25, 6:46 AM · Restricted Project
OmerAviram updated the diff for D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet..
Thu, Nov 25, 6:11 AM · Restricted Project
OmerAviram updated the diff for D114575: [X86] Add vector test coverage for or with no common bits tests.
Thu, Nov 25, 6:10 AM · Restricted Project
OmerAviram updated the summary of D114575: [X86] Add vector test coverage for or with no common bits tests.
Thu, Nov 25, 1:56 AM · Restricted Project
OmerAviram updated the diff for D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet..

Added tests for vector types.

Thu, Nov 25, 1:55 AM · Restricted Project
OmerAviram requested review of D114575: [X86] Add vector test coverage for or with no common bits tests.
Thu, Nov 25, 1:47 AM · Restricted Project

Wed, Nov 24

OmerAviram added a comment to D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet..

Do we expect all vector types/targets to bypass this in some way? If yes, it's worth adding a comment to the patch description and/or code. If no, can we find a test that shows an asm difference?

Wed, Nov 24, 8:01 AM · Restricted Project
OmerAviram added a comment to D114078: [X86] Add tests cases for or-lea with no common bits..

@OmerAviram Do you have commit access?

Wed, Nov 24, 4:05 AM · Restricted Project
OmerAviram updated the diff for D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet..

Updated diff with i32 and i64 tests.

Wed, Nov 24, 1:11 AM · Restricted Project
OmerAviram updated the diff for D114078: [X86] Add tests cases for or-lea with no common bits..
Wed, Nov 24, 12:47 AM · Restricted Project

Mon, Nov 22

OmerAviram added inline comments to D114078: [X86] Add tests cases for or-lea with no common bits..
Mon, Nov 22, 7:05 AM · Restricted Project

Wed, Nov 17

OmerAviram updated the diff for D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet..

Added tests for the different pattern permutations as a separate patch (https://reviews.llvm.org/D114078) and rebased on it.

Wed, Nov 17, 4:59 AM · Restricted Project
OmerAviram requested review of D114078: [X86] Add tests cases for or-lea with no common bits..
Wed, Nov 17, 4:50 AM · Restricted Project

Tue, Nov 16

OmerAviram updated the diff for D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet..

Added ll test for X86 Target.
prior to the patch, the ir included an or instruction:

Tue, Nov 16, 6:59 AM · Restricted Project
OmerAviram added reviewers for D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet.: guyblank, alonkom.
Tue, Nov 16, 2:34 AM · Restricted Project
OmerAviram requested review of D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet..
Tue, Nov 16, 12:54 AM · Restricted Project