This is an archive of the discontinued LLVM Phabricator instance.

Add a clang-transformer tutorial
ClosedPublic

Authored by ymandel on Nov 16 2021, 9:49 AM.

Details

Summary

This patch adds a tutorial for the ClangTransformer library in libTooling (clang/Tooling/Transformer).

Diff Detail

Event Timeline

ymandel created this revision.Nov 16 2021, 9:49 AM
ymandel edited the summary of this revision. (Show Details)Nov 16 2021, 11:32 AM
ymandel added reviewers: gribozavr2, aaron.ballman.
ymandel changed the edit policy from "All Users" to "ymandel (Yitzhak Mandelbaum)".
ymandel added a project: Restricted Project.
ymandel published this revision for review.Nov 16 2021, 11:38 AM
ymandel updated this revision to Diff 387906.Nov 17 2021, 5:07 AM

removed stray internal reference.

ymandel changed the edit policy from "ymandel (Yitzhak Mandelbaum)" to "All Users".Nov 17 2021, 5:08 AM
gribozavr2 accepted this revision.Nov 17 2021, 5:08 AM
gribozavr2 added inline comments.
clang/docs/ClangTransformerTutorial.rst
53

Please use relative links:

:doc:`LibASTMatchers`
65

Does this link work? Or does it need to use the RST syntax?

70

"an api" -> "a style guide rule"?

95

"renaming a function"

321

Remove "and"?

356

"of a particular"

397

Please use relative links with :doc:.

This revision is now accepted and ready to land.Nov 17 2021, 5:08 AM
ymandel updated this revision to Diff 387914.Nov 17 2021, 5:35 AM

Responses to comments

ymandel marked 7 inline comments as done.Nov 17 2021, 5:37 AM

Thanks for the review!

clang/docs/ClangTransformerTutorial.rst
70

yes. this example came from an API with its own style guide. :)

This revision was landed with ongoing or failed builds.Nov 17 2021, 5:41 AM
This revision was automatically updated to reflect the committed changes.
ymandel marked an inline comment as done.