Page MenuHomePhabricator

[mlir][LLVM] Fix folding of LLVM::ExtractValueOp
ClosedPublic

Authored by nicolasvasilache on Tue, Nov 16, 2:06 AM.

Details

Summary

Limit the backtracking along def-use chains when a prefix is encountered as it would generate incorrect foldings.

Diff Detail

Event Timeline

nicolasvasilache requested review of this revision.Tue, Nov 16, 2:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Nov 16, 2:06 AM
gysit accepted this revision.Tue, Nov 16, 4:21 AM
gysit added inline comments.
mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
1161

nit: should

1167

nit: auto format wraps the lines in at an unfortunate position. maybe everything fits one line after removing the indention.

This revision is now accepted and ready to land.Tue, Nov 16, 4:21 AM
This revision was landed with ongoing or failed builds.Tue, Nov 16, 6:49 AM
This revision was automatically updated to reflect the committed changes.