This is an archive of the discontinued LLVM Phabricator instance.

Differential D113882

[llvm-nm][test] Move X86 lit.local.cfg into the X86 subfolder
ClosedPublic

Authored by jhenderson on Nov 15 2021, 3:54 AM.

Details

Reviewers
MaskRay
rupprecht
mstorsjo
tmiasko
Commits
rG254aa65d0487: [llvm-nm][test] Move X86 lit.local.cfg into the X86 subfolder
Summary

The file seems to have been put in the wrong place in its original commit. This had the effect of marking all llvm-nm tests as unsupported, unless X86 was enabled, even for tests that weren't X86 specific.

Fixes https://bugs.llvm.org/show_bug.cgi?id=52506.

Diff Detail

Event Timeline

jhenderson created this revision.Nov 15 2021, 3:54 AM
Herald added a subscriber: pengfei. · View Herald TranscriptNov 15 2021, 3:54 AM
jhenderson requested review of this revision.Nov 15 2021, 3:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 15 2021, 3:54 AM
Harbormaster completed remote builds in B134214: Diff 387198.Nov 15 2021, 4:54 AM
mstorsjo accepted this revision.Nov 15 2021, 4:55 AM

LGTM

This revision is now accepted and ready to land.Nov 15 2021, 4:55 AM
Closed by commit rG254aa65d0487: [llvm-nm][test] Move X86 lit.local.cfg into the X86 subfolder (authored by jhenderson). · Explain WhyNov 15 2021, 5:05 AM
This revision was automatically updated to reflect the committed changes.
jhenderson added a commit: rG254aa65d0487: [llvm-nm][test] Move X86 lit.local.cfg into the X86 subfolder.
MaskRay added a comment.Nov 15 2021, 10:17 AM

Thanks!

Revision Contents

PathSize
llvm/
test/
tools/
llvm-nm/
X86/

Diff 387221

llvm/test/tools/llvm-nm/X86/lit.local.cfg

  • This file was moved from llvm/test/tools/llvm-nm/lit.local.cfg.
The contents of this file were not changed.

llvm/test/tools/llvm-nm/lit.local.cfg

  • This file was moved to llvm/test/tools/llvm-nm/X86/lit.local.cfg.