This is an archive of the discontinued LLVM Phabricator instance.

[mlir] spirv: Regenerate SPIRVBase.td from recent spec
ClosedPublic

Authored by Hardcode84 on Nov 11 2021, 5:42 AM.

Details

Summary
  • Initially I only wanted to add SPV_EXT_shader_atomic_float_add and corresponding extensions but I didn't find a way to do this without regenerating entire file
  • Some long names were added and script decided to change whitespaces in a lot of places
  • ImageOperand was renamed to ImageOperands in spec
  • Some *NV enums were renamed to *KHR (spec actually maintains both variants with same value, but script pulled only *KHR versions)

Diff Detail

Event Timeline

Hardcode84 created this revision.Nov 11 2021, 5:42 AM
Hardcode84 requested review of this revision.Nov 11 2021, 5:42 AM
Hardcode84 added inline comments.Nov 11 2021, 5:45 AM
mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td
3601

This change, pulled from spec, seems to broke some tests. I have no idea is this correct or not, @antiagainst can you take a look?

Nice, thanks for refreshing this! I'll patch and land it. :)

mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td
3601

Yes, This is a known issue with the upstream JSON grammar. See details here: https://github.com/KhronosGroup/SPIRV-Headers/pull/136. I was trying to fix that but gotten distracted (and never came back to it). Oops..

For now I'll just manually patch this..

antiagainst accepted this revision.Nov 11 2021, 1:49 PM
This revision is now accepted and ready to land.Nov 11 2021, 1:49 PM
This revision was landed with ongoing or failed builds.Nov 11 2021, 2:09 PM
This revision was automatically updated to reflect the committed changes.