- Initially I only wanted to add SPV_EXT_shader_atomic_float_add and corresponding extensions but I didn't find a way to do this without regenerating entire file
- Some long names were added and script decided to change whitespaces in a lot of places
- ImageOperand was renamed to ImageOperands in spec
- Some *NV enums were renamed to *KHR (spec actually maintains both variants with same value, but script pulled only *KHR versions)
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td | ||
---|---|---|
3601 | This change, pulled from spec, seems to broke some tests. I have no idea is this correct or not, @antiagainst can you take a look? |
Comment Actions
Nice, thanks for refreshing this! I'll patch and land it. :)
mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td | ||
---|---|---|
3601 | Yes, This is a known issue with the upstream JSON grammar. See details here: https://github.com/KhronosGroup/SPIRV-Headers/pull/136. I was trying to fix that but gotten distracted (and never came back to it). Oops.. For now I'll just manually patch this.. |
This change, pulled from spec, seems to broke some tests. I have no idea is this correct or not, @antiagainst can you take a look?