[lldb] Hyphenate Objective-C exception breakpoint labels ✍️

[stephanemoore]

Summary

Objective-C is officially hyphenated:
https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/ObjectiveC/Introduction/introObjectiveC.html#//apple_ref/doc/uid/TP30001163

[stephanemoore]

Updated.

[mwyman]

LGTM

[mwyman]

LGTM.

[JDevlieghere]

This seems trivial enough, but adding Greg as he wrote most of lldb-vscode.

[stephanemoore]

In D113616#3341803, @JDevlieghere wrote:

This seems trivial enough, but adding Greg as he wrote most of lldb-vscode.

Thanks! 😃

I tried looking through the commit history but wasn't sure who would be a good candidate to review.

I also assume this should be a trivial change but I am happy to do extra digging if anyone has any concerns!

[clayborg]

Very easy change as VS Code IDE displays these strings and no one references these by name.

[stephanemoore]

In D113616#3347980, @clayborg wrote:

Very easy change as VS Code IDE displays these strings and no one references these by name.

I thought so! Thanks for confirming!

lldb/tools/lldb-vscode/VSCode.cpp

 
 VSCode g_vsc;
 
 VSCode::VSCode()
     : broadcaster("lldb-vscode"),
       exception_breakpoints(
           {{"cpp_catch", "C++ Catch", lldb::eLanguageTypeC_plus_plus},
            {"cpp_throw", "C++ Throw", lldb::eLanguageTypeC_plus_plus},
-           {"objc_catch", "Objective C Catch", lldb::eLanguageTypeObjC},
-           {"objc_throw", "Objective C Throw", lldb::eLanguageTypeObjC},
+           {"objc_catch", "Objective-C Catch", lldb::eLanguageTypeObjC},
+           {"objc_throw", "Objective-C Throw", lldb::eLanguageTypeObjC},
            {"swift_catch", "Swift Catch", lldb::eLanguageTypeSwift},
            {"swift_throw", "Swift Throw", lldb::eLanguageTypeSwift}}),
       focus_tid(LLDB_INVALID_THREAD_ID), sent_terminated_event(false),
       stop_at_entry(false), is_attach(false), reverse_request_seq(0),
       waiting_for_run_in_terminal(false),
       progress_event_reporter(
           [&](const ProgressEvent &event) { SendJSON(event.ToJSON()); }) {
   const char *log_file_path = getenv("LLDBVSCODE_LOG");