- User Since
- Apr 12 2019, 9:40 AM (114 w, 1 d)
Apr 10 2020
Added struct member reference from local variable, per review comment.
Apr 9 2020
Add check for isScalarType before getting the type, which seems to be triggering an assert. Maybe this is a Mac vs Linux thing?
Adding non-object types for argument to getArgument:atIndex: to verify they don't cause problems.
Add matching MemberRefExpr case, not just the non-matching case there was before.
Updating per Stephane's comments. To deal with struct fields needed to match MemberRefExprs.
Apr 8 2020
Renamed NsinvocationArgumentLifetimeCheck -> NSInvocationArgumentLifetimeCheck to match other ObjC checker names.
Apr 6 2020
Missed CHECK-FIXES for block argument.
Trying to fix Harbormaster build.
Responding to review feedback.
Check for Objective-C block pointers as well, which also require __unsafe_unretained when retrieved as arguments from NSInvocation under ARC.
Mar 11 2020
After some discussion, have decided to remove the fix-it entirely and update the diagnostic message; removing the method altogether may not be the correct behavior, as previously deprecated methods that have since been removed may want to have an unavailable attribute attached with a message explaining what to use instead, even though they don't override a superclass method.
Mar 6 2020
Update documentation to include description of the FixMacroNames config option.
Mar 5 2020
Updated per review feedback.
Don't provide fix-it hints when the unavailable attribute is inside a macro, unless within a config-whitelisted macro.
I goofed on updating with Arcanist—the changes I marked done will be incoming shortly!
Mar 4 2020
Updated documentation per review comments.
Updated to explicitly check for attribute((unavailable)), to avoid flagging methods marked based on platform availability. Updated test file to validate this.
Mar 3 2020
Feb 6 2020
Updated based on feedback.
Make check class final, based on feedback.`
Feb 4 2020
Revert script-changed file.
Jan 30 2020
Implemented review feedback.
Jan 27 2020
Updated the diff based on review feedback.
Addresses reviewer feedback.
Jan 16 2020
Fixed missing end quote pointed out in review comment.
Sep 30 2019
Sep 27 2019
Moved release note below list of new checks.
Sep 26 2019
Tweaked release notes to match first sentence of documentation.
Addressed Stephane's review feedback.
Rebased patch to apply to current master.
Sep 18 2019
Addressed review comments.
Sep 16 2019
Migrated check to new darwin module.
Sep 13 2019
Moved the assignment check to a separate review.
May 22 2019
Syncing code with HEAD
May 14 2019
Bah, previous changes not caught in Git commit; switching back and forth between Git/Mercurial makes for some mix-ups, I guess.
May 13 2019
Added +new declaration for ProxyFoo.
Update for comments
May 10 2019
I don't have commit access, so if somebody could submit them that would be wonderful!
May 8 2019
Update for review comments.
May 7 2019
Update comments/doc based on feedback.
Updated to address code review comments.
May 1 2019
Updated per review comments.
Fixes per review comments.
Apr 30 2019
Apr 22 2019
Thanks. I don't believe I have commit access, so I'll need someone to commit this to trunk.