Page MenuHomePhabricator

mwyman (Michael Wyman)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 12 2019, 9:40 AM (23 w, 1 d)

Recent Activity

Wed, Sep 18

mwyman updated the diff for D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.

Addressed review comments.

Wed, Sep 18, 2:24 PM · Restricted Project, Restricted Project

Mon, Sep 16

mwyman updated the diff for D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.

Migrated check to new darwin module.

Mon, Sep 16, 10:31 AM · Restricted Project, Restricted Project
mwyman added a comment to D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.
In D67567#1670264, @NoQ wrote:

FTR, we already have a similar Static Analyzer check, eg.:
https://github.com/llvm-mirror/clang/blob/release_80/test/Analysis/dispatch-once.m#L15
https://github.com/llvm-mirror/clang/blob/release_80/test/Analysis/dispatch-once.m#L26

Your check is a bit more aggressive but i don't see why didn't we do it that way in the first place :) Though you won't be able to warn on the heap example.

Mon, Sep 16, 10:04 AM · Restricted Project, Restricted Project

Fri, Sep 13

mwyman added a comment to D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.
  1. Please split each check into separate review.
  2. Is dispatch_once_t OSX-specific thing? Should those checks be in osx module?
  1. I split the review.
  1. I don't see an osx module—am I somehow missing seeing it?

One can be added.

dispatch_once_t is something from libdispatchwhich is an Apple-created API, but is OSS and available outside Apple. It's also a C API, which is why I didn't feel objc was an appropriate module either. I'm open to a better home module for this check, it's just not clear to me where that might be.

No opinion on my question, just thought it should be asked,

Fri, Sep 13, 3:47 PM · Restricted Project, Restricted Project
mwyman created D67578: [clang-tidy] New check to warn when writing to a dispatch_once_t variable..
Fri, Sep 13, 3:29 PM · Restricted Project, Restricted Project
mwyman added a comment to D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.
  1. Please split each check into separate review.
  2. Is dispatch_once_t OSX-specific thing? Should those checks be in osx module?
Fri, Sep 13, 2:21 PM · Restricted Project, Restricted Project
mwyman retitled D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage from New ClangTidy checks to warn when storing dispatch_once_t in non-static, non-global storage to New ClangTidy check to warn when storing dispatch_once_t in non-static, non-global storage.
Fri, Sep 13, 2:09 PM · Restricted Project, Restricted Project
mwyman updated the diff for D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.

Moved the assignment check to a separate review.

Fri, Sep 13, 2:07 PM · Restricted Project, Restricted Project
mwyman created D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.
Fri, Sep 13, 12:02 PM · Restricted Project, Restricted Project

May 22 2019

mwyman updated the diff for D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.

Syncing code with HEAD

May 22 2019, 2:47 PM · Restricted Project, Restricted Project

May 14 2019

mwyman updated the diff for D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.

Bah, previous changes not caught in Git commit; switching back and forth between Git/Mercurial makes for some mix-ups, I guess.

May 14 2019, 12:49 AM · Restricted Project, Restricted Project

May 13 2019

mwyman updated the diff for D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.

Added +new declaration for ProxyFoo.

May 13 2019, 3:38 PM · Restricted Project, Restricted Project
mwyman updated the diff for D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.

Update for comments

May 13 2019, 3:09 PM · Restricted Project, Restricted Project

May 10 2019

mwyman accepted D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.

I don't have commit access, so if somebody could submit them that would be wonderful!

May 10 2019, 1:31 PM · Restricted Project, Restricted Project
mwyman accepted D61769: [clang] Regenerate AST matcher docs 📖.
May 10 2019, 9:29 AM · Restricted Project, Restricted Project

May 8 2019

mwyman updated the diff for D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.

Update for review comments.

May 8 2019, 11:16 AM · Restricted Project, Restricted Project
mwyman added inline comments to D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.
May 8 2019, 11:16 AM · Restricted Project, Restricted Project

May 7 2019

mwyman updated the diff for D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.

Update comments/doc based on feedback.

May 7 2019, 11:30 AM · Restricted Project, Restricted Project
mwyman added inline comments to D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.
May 7 2019, 10:05 AM · Restricted Project, Restricted Project
mwyman updated the diff for D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.

Updated to address code review comments.

May 7 2019, 10:03 AM · Restricted Project, Restricted Project

May 1 2019

mwyman updated the diff for D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.

Updated per review comments.

May 1 2019, 5:47 PM · Restricted Project, Restricted Project
mwyman updated the diff for D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.

Fixes per review comments.

May 1 2019, 4:45 PM · Restricted Project, Restricted Project

Apr 30 2019

mwyman created D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.
Apr 30 2019, 3:33 PM · Restricted Project, Restricted Project

Apr 22 2019

mwyman accepted D60920: [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`, and `isInstanceMethod`.

Thanks. I don't believe I have commit access, so I'll need someone to commit this to trunk.

Apr 22 2019, 10:28 AM · Restricted Project

Apr 19 2019

mwyman created D60920: [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`, and `isInstanceMethod`.
Apr 19 2019, 1:57 PM · Restricted Project