Down the path, if there is a implicit instantiation, this may trigger
the assertion "Member specialization must be an explicit specialization"
in clang::FunctionDecl::setFunctionTemplateSpecialization.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Thanks for the fix for this -- I think the changes look like they're correct, but the test coverage needs a bit of work.
clang/lib/Sema/SemaDecl.cpp | ||
---|---|---|
9191 | Alternatively, we could set Invalid = true; here and let the code on 9207 do its thing. We do both in this function, and I believe either approach is equivalent for this specific code path. | |
clang/test/CXX/temp/temp.spec/temp.expl.spec/p20.cpp | ||
16–28 | I don't think you should coop the existing test for an unrelated bug; can you add a new test to either SemaCXX or SemaTemplate? |
Alternatively, we could set Invalid = true; here and let the code on 9207 do its thing. We do both in this function, and I believe either approach is equivalent for this specific code path.