Page MenuHomePhabricator

Adding a key_type definition to MapVector
ClosedPublic

Authored by kevcadieux on Thu, Nov 4, 10:00 PM.

Details

Summary

The key_type type definition for map containers is useful in some generic, template-based programming scenarios. The addition of key_type to MapVector is consistent with other map types like DenseMap.

Diff Detail

Event Timeline

kevcadieux created this revision.Thu, Nov 4, 10:00 PM
kevcadieux requested review of this revision.Thu, Nov 4, 10:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Nov 4, 10:00 PM

There are build failures due to a failed Polly test

test/ScopInliner/simple-inline-loop.ll

After reproducing it locally, I verified that this failure occurs even without my change.

Thanks for letting me know. Do you know what is the proper way to trigger a remerge before building? I tried simply restarting the build but it didn't include the fix.

Thanks for letting me know. Do you know what is the proper way to trigger a remerge before building?

The only way I know is re-uploading the diff.

I tried simply restarting the build but it didn't include the fix.

If you upload with arcanist it also stores the parent git SHA1 and would just re-apply the patch to that. If you upload via web form Phabricator does not have parent information, but I don't know what happens when triggering a re-build. Might either use the opt-of-tree at time of uploading the diff or the top-of-tree when running the pre-merge check.

This revision is now accepted and ready to land.Fri, Nov 12, 9:43 PM

LGTM.

Thanks for approving! I don't have commit privileges since this is my first contribution. Could you please do me a favor and commit it for me? Thanks!

Sure—please let me know the email address and author name to I use for attribution!

Sure—please let me know the email address and author name to I use for attribution!

Author name: Kevin Cadieux
Email: kevca@microsoft.com

This revision was automatically updated to reflect the committed changes.