Page MenuHomePhabricator

kevcadieux (Kevin Cadieux)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 29 2021, 5:19 PM (56 w, 5 d)

Recent Activity

Jun 29 2022

kevcadieux added a comment to D128874: [lldb] Fix unused variable warning in TraceHTR (NFC).

thanks!

Jun 29 2022, 9:25 PM · Restricted Project, Restricted Project
kevcadieux added reviewers for D128874: [lldb] Fix unused variable warning in TraceHTR (NFC): wallace, stella.stamenova.
Jun 29 2022, 9:04 PM · Restricted Project, Restricted Project
kevcadieux requested review of D128874: [lldb] Fix unused variable warning in TraceHTR (NFC).
Jun 29 2022, 9:03 PM · Restricted Project, Restricted Project
kevcadieux added a comment to D128786: [clang-format] Fix incorrect isspace input (NFC).

FYI: failure looks like the following:

Jun 29 2022, 2:25 AM · Restricted Project, Restricted Project, Restricted Project
kevcadieux added a comment to D124748: [clang-format] Fix whitespace counting stuff.

@sstwcw @HazardyKnusperkeks : this change introduced a regression in one of the clang format unit tests. I fixed it in the revision below. Could anyone please take a look / approve this revision to unblock Windows debug builds? Thanks!

Jun 29 2022, 2:22 AM · Restricted Project, Restricted Project, Restricted Project
kevcadieux added reviewers for D128786: [clang-format] Fix incorrect isspace input (NFC): sstwcw, HazardyKnusperkeks, stella.stamenova.
Jun 29 2022, 12:35 AM · Restricted Project, Restricted Project, Restricted Project

Jun 28 2022

kevcadieux requested review of D128786: [clang-format] Fix incorrect isspace input (NFC).
Jun 28 2022, 11:42 PM · Restricted Project, Restricted Project, Restricted Project

Mar 8 2022

kevcadieux added a comment to D121102: Update more `parseSourceString()` call sites..

Hello @csigg, there seems to be another use of the deprecated parseSourceString function in mlir/lib/CAPI/IR/IR.cpp that is causing a deprecated error in our builds. Would you mind please updating that use as well? Thanks!

Done.

Does that mean that we are not supposed to mark things deprecated?
Or would it make sense to only treat deprecations as warnings in your build?

Mar 8 2022, 9:56 PM · Restricted Project, Restricted Project

Mar 7 2022

kevcadieux added a comment to D121102: Update more `parseSourceString()` call sites..

Hello @csigg, there seems to be another use of the deprecated parseSourceString function in mlir/lib/CAPI/IR/IR.cpp that is causing a deprecated error in our builds. Would you mind please updating that use as well? Thanks!

Mar 7 2022, 9:42 PM · Restricted Project, Restricted Project

Nov 22 2021

kevcadieux added a comment to D113809: [MachO] Fix struct size assertion.

https://github.com/llvm/llvm-project/commit/2f5d6a0ea51b should fix the assertion. Sorry for the breakage here.

Nov 22 2021, 4:08 PM · Restricted Project, Restricted Project
kevcadieux added a comment to D113809: [MachO] Fix struct size assertion.

We are also seeing this in our internal Windows builds. As can be seen below, the size difference in debug is due to the std::vector<lld::macho::Reloc> member, which is actually due to the _Vector_val internal vector member that uses a different base class in debug mode (std::_Container_base12 instead of std::_Container_base0). Could we simply turn off this static assert for debug builds (e.g. with #ifdef NDEBUG)?

Nov 22 2021, 2:17 PM · Restricted Project, Restricted Project

Nov 16 2021

kevcadieux added a comment to D113242: Adding a key_type definition to MapVector.

Sure—please let me know the email address and author name to I use for attribution!

Nov 16 2021, 5:31 PM · Restricted Project
kevcadieux added a comment to D113242: Adding a key_type definition to MapVector.

LGTM.

Nov 16 2021, 4:18 PM · Restricted Project

Nov 9 2021

kevcadieux added a reviewer for D113242: Adding a key_type definition to MapVector: Eugene.Zelenko.
Nov 9 2021, 10:23 AM · Restricted Project

Nov 7 2021

kevcadieux added a reviewer for D113242: Adding a key_type definition to MapVector: manbearian.
Nov 7 2021, 5:33 PM · Restricted Project
kevcadieux updated kevcadieux.
Nov 7 2021, 11:17 AM
kevcadieux updated kevcadieux.
Nov 7 2021, 11:14 AM

Nov 6 2021

kevcadieux updated the diff for D113242: Adding a key_type definition to MapVector.

Rebasing.

Nov 6 2021, 9:45 PM · Restricted Project

Nov 5 2021

kevcadieux added a comment to D113242: Adding a key_type definition to MapVector.
Nov 5 2021, 2:34 PM · Restricted Project

Nov 4 2021

kevcadieux added a comment to D113242: Adding a key_type definition to MapVector.

There are build failures due to a failed Polly test

test/ScopInliner/simple-inline-loop.ll
Nov 4 2021, 11:49 PM · Restricted Project
kevcadieux added a reviewer for D113242: Adding a key_type definition to MapVector: dexonsmith.
Nov 4 2021, 10:03 PM · Restricted Project
kevcadieux requested review of D113242: Adding a key_type definition to MapVector.
Nov 4 2021, 10:00 PM · Restricted Project