Page MenuHomePhabricator

kevcadieux (Kevin Cadieux)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 29 2021, 5:19 PM (5 w, 2 d)

Recent Activity

Mon, Nov 22

kevcadieux added a comment to D113809: [MachO] Fix struct size assertion.

https://github.com/llvm/llvm-project/commit/2f5d6a0ea51b should fix the assertion. Sorry for the breakage here.

Mon, Nov 22, 4:08 PM · Restricted Project, Restricted Project
kevcadieux added a comment to D113809: [MachO] Fix struct size assertion.

We are also seeing this in our internal Windows builds. As can be seen below, the size difference in debug is due to the std::vector<lld::macho::Reloc> member, which is actually due to the _Vector_val internal vector member that uses a different base class in debug mode (std::_Container_base12 instead of std::_Container_base0). Could we simply turn off this static assert for debug builds (e.g. with #ifdef NDEBUG)?

Mon, Nov 22, 2:17 PM · Restricted Project, Restricted Project

Tue, Nov 16

kevcadieux added a comment to D113242: Adding a key_type definition to MapVector.

Sure—please let me know the email address and author name to I use for attribution!

Tue, Nov 16, 5:31 PM · Restricted Project
kevcadieux added a comment to D113242: Adding a key_type definition to MapVector.

LGTM.

Tue, Nov 16, 4:18 PM · Restricted Project

Tue, Nov 9

kevcadieux added a reviewer for D113242: Adding a key_type definition to MapVector: Eugene.Zelenko.
Tue, Nov 9, 10:23 AM · Restricted Project

Sun, Nov 7

kevcadieux added a reviewer for D113242: Adding a key_type definition to MapVector: manbearian.
Sun, Nov 7, 5:33 PM · Restricted Project
kevcadieux updated kevcadieux.
Sun, Nov 7, 11:17 AM
kevcadieux updated kevcadieux.
Sun, Nov 7, 11:14 AM

Sat, Nov 6

kevcadieux updated the diff for D113242: Adding a key_type definition to MapVector.

Rebasing.

Sat, Nov 6, 9:45 PM · Restricted Project

Nov 5 2021

kevcadieux added a comment to D113242: Adding a key_type definition to MapVector.
Nov 5 2021, 2:34 PM · Restricted Project

Nov 4 2021

kevcadieux added a comment to D113242: Adding a key_type definition to MapVector.

There are build failures due to a failed Polly test

test/ScopInliner/simple-inline-loop.ll
Nov 4 2021, 11:49 PM · Restricted Project
kevcadieux added a reviewer for D113242: Adding a key_type definition to MapVector: dexonsmith.
Nov 4 2021, 10:03 PM · Restricted Project
kevcadieux requested review of D113242: Adding a key_type definition to MapVector.
Nov 4 2021, 10:00 PM · Restricted Project