This is an archive of the discontinued LLVM Phabricator instance.

[VE] Disable incompatible compiler-rt tests
ClosedPublic

Authored by simoll on Nov 3 2021, 3:05 AM.

Details

Summary

Some compiler-rt tests are inherently incompatible with VE because..

  • No consistent denormal support on VE. We skip denormal fp inputs in builtin tests.
  • madvise unsupported on VE.
  • Instruction alignment requirements.

Diff Detail

Event Timeline

simoll requested review of this revision.Nov 3 2021, 3:05 AM
simoll created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2021, 3:05 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
simoll edited the summary of this revision. (Show Details)Nov 3 2021, 3:08 AM
simoll edited the summary of this revision. (Show Details)Nov 4 2021, 3:35 AM
simoll added a reviewer: phosek.
simoll retitled this revision from [VE] Adapt tests to pass on VE to [VE] Silence incompatible compiler-rt tests.
phosek added inline comments.Nov 8 2021, 10:16 AM
compiler-rt/lib/profile/InstrProfilingUtil.c
370

I'd prefer changing the condition here instead.

compiler-rt/test/builtins/Unit/enable_execute_stack_test.c
37–38

INSTR_ALIGNMENT_BYTE isn't used anywhere else so I'd prefer inlining it here.

simoll updated this revision to Diff 385733.Nov 9 2021, 1:35 AM
simoll retitled this revision from [VE] Silence incompatible compiler-rt tests to [VE] Disable incompatible compiler-rt tests.
simoll edited the summary of this revision. (Show Details)

Addressed phosek's comments (thx!)

simoll marked 2 inline comments as done.Nov 9 2021, 1:36 AM
phosek accepted this revision.Nov 10 2021, 10:40 AM

LGTM

This revision is now accepted and ready to land.Nov 10 2021, 10:40 AM
simoll updated this revision to Diff 386434.Nov 10 2021, 11:45 PM

NFC

  • remove spurious newline
  • #ifdef-out entire body of lprofReleaseMemoryPagesToOS for VE (MADV_DONTNEED isn't defined).
This revision was automatically updated to reflect the committed changes.