This is an archive of the discontinued LLVM Phabricator instance.

[LoopPeel] Add EXPENSIVE_CHECKS ifdef guard around domtree verify call
ClosedPublic

Authored by steplong on Nov 2 2021, 9:39 AM.

Details

Summary

The verify call was taking 50% of the compile time in our internal LLVM fork when trying to unroll many loops.

Diff Detail

Event Timeline

steplong created this revision.Nov 2 2021, 9:39 AM
steplong requested review of this revision.Nov 2 2021, 9:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2021, 9:39 AM
steplong edited the summary of this revision. (Show Details)Nov 2 2021, 9:40 AM
efriedma accepted this revision.Nov 3 2021, 11:46 AM
efriedma added a subscriber: efriedma.

LGTM

You could maybe add a flag to control this, but probably not important.

This revision is now accepted and ready to land.Nov 3 2021, 11:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2022, 9:57 AM