This is an archive of the discontinued LLVM Phabricator instance.

[lld-macho] Remove no_dtrace_dof from un-implemented group.
ClosedPublic

Authored by oontvoo on Nov 1 2021, 9:08 AM.

Details

Summary

One fewer warning.
In practice, lld already "implements" it. (ie., it does not do dtrace-dof processing ever).

Diff Detail

Event Timeline

oontvoo created this revision.Nov 1 2021, 9:08 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: dang. · View Herald Transcript
oontvoo requested review of this revision.Nov 1 2021, 9:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 1 2021, 9:08 AM
thakis accepted this revision.Nov 2 2021, 7:09 AM
thakis added a subscriber: thakis.

Want to add a quick RUN: %lld -no_dtrace_dof line to lld/test/MachO/driver.test to make sure this no longer emits a warning? With that, lg.

lld/MachO/Options.td
950

Just "Disable dtrace-dof processing (default)" seems sufficient. Brevity good.

This revision is now accepted and ready to land.Nov 2 2021, 7:09 AM
thakis added a comment.Nov 2 2021, 7:11 AM

Actually lld/test/MachO/silent-ignore.test is a better file for the test.

oontvoo updated this revision to Diff 384128.Nov 2 2021, 8:47 AM
oontvoo marked an inline comment as done.

added test + shortened helptext