This is an archive of the discontinued LLVM Phabricator instance.

Tests for additional builtin classification functions
AbandonedPublic

Authored by sepavloff on Nov 1 2021, 8:33 AM.

Details

Summary

Tests for additional builtin classification functions

This change adds tests for functions 'iszero', 'issubnornal' and 'issignaling'.
It also adds tests for Intel fp80 type and some other small enhancements.

Event Timeline

sepavloff requested review of this revision.Nov 1 2021, 8:33 AM
sepavloff created this revision.
sepavloff updated this revision to Diff 385519.Nov 8 2021, 8:49 AM

Restore support of long double

sepavloff updated this revision to Diff 410307.Feb 21 2022, 7:50 AM

Added support of x86 extended precision format

arsenm added a subscriber: arsenm.Jun 1 2023, 10:33 AM
arsenm added inline comments.
SingleSource/UnitTests/Float/classify-f32.h
147

Use named macros for these?

SingleSource/UnitTests/Float/classify-f80.h
234 ↗(On Diff #410307)

Use array indexing syntax?

Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2023, 10:33 AM

Update the patch

sepavloff retitled this revision from [WIP] Tests for additional builtin classification functions to Tests for additional builtin classification functions.Mon, Nov 20, 11:10 AM
sepavloff edited the summary of this revision. (Show Details)
sepavloff added inline comments.Mon, Nov 20, 11:20 AM
SingleSource/UnitTests/Float/classify-f32.h
147

Did you mean using FP_NAN instead of 0, FP_INFINITE instead of 1 and so on?

SingleSource/UnitTests/Float/classify-f80.h
234 ↗(On Diff #410307)

Actually ExtendedDoubleZeroValues is an array of 128-bit entities, represented as pairs of 64-bit ones. So using array syntax is not possible.

Was this moved to a PR? Can that be linked and this abandoned?

sepavloff abandoned this revision.Wed, Dec 6, 10:57 AM

Was this moved to a PR? Can that be linked and this abandoned?

It should has been moved, - Phabricator stopped sending mail notifications, and I overlooked your feedback, sorry.

Now it is the PR: https://github.com/llvm/llvm-test-suite/pull/59.