Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Paths

Table of Contentst

Tests for additional builtin classification functions
Needs ReviewPublic
Actions

Authored by sepavloff on Nov 1 2021, 8:33 AM.

Details

Reviewers

arsenm
craig.topper
aaron.ballman

Summary

Tests for additional builtin classification functions

This change adds tests for functions 'iszero', 'issubnornal' and 'issignaling'.
It also adds tests for Intel fp80 type and some other small enhancements.

Diff Detail

Repository

rT test-suite

Build Status

Buildable 258102
Build 402471: arc lint + arc unit

Event Timeline

sepavloff requested review of this revision.Nov 1 2021, 8:33 AM

sepavloff created this revision.

Harbormaster completed remote builds in B131751: Diff 383809.Nov 1 2021, 8:33 AM

sepavloff added a parent revision: D112932: Use llvm.is_fpclass to implement FP classification functions.Nov 1 2021, 8:36 AM

sepavloff mentioned this in D112025: Intrinsic for checking floating point class.Nov 1 2021, 8:44 AM

Restore support of long double

Harbormaster completed remote builds in B133038: Diff 385519.Nov 8 2021, 8:49 AM

sepavloff mentioned this in D113414: [X86] Custom lowering of llvm.is_fpclass for x86_fp80.Nov 8 2021, 9:13 AM

sepavloff mentioned this in D113908: [PowerPC] Support of ppc_fp128 in lowering of llvm.is_fpclass.Nov 15 2021, 9:04 AM

Added support of x86 extended precision format

Harbormaster completed remote builds in B150698: Diff 410307.Feb 21 2022, 7:50 AM

sepavloff mentioned this in rG9fc58f1820e3: [PowerPC] Support of ppc_fp128 in lowering of llvm.is_fpclass.Apr 28 2022, 9:12 PM

arsenm added a subscriber: arsenm.Jun 1 2023, 10:33 AM

arsenm added inline comments.

SingleSource/UnitTests/Float/classify-f32.h
107	Use named macros for these?
SingleSource/UnitTests/Float/classify-f80.h
235	Use array indexing syntax?

Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2023, 10:33 AM

Update the patch

Harbormaster completed remote builds in B258102: Diff 558138.Mon, Nov 20, 11:04 AM

sepavloff retitled this revision from [WIP] Tests for additional builtin classification functions to Tests for additional builtin classification functions.Mon, Nov 20, 11:10 AM

sepavloff edited the summary of this revision. (Show Details)

sepavloff added reviewers: arsenm, craig.topper, aaron.ballman.

Herald added a subscriber: wdng. · View Herald TranscriptMon, Nov 20, 11:10 AM

sepavloff added inline comments.Mon, Nov 20, 11:20 AM

SingleSource/UnitTests/Float/classify-f32.h
107	Did you mean using `FP_NAN` instead of 0, `FP_INFINITE` instead of 1 and so on?
SingleSource/UnitTests/Float/classify-f80.h
235	Actually `ExtendedDoubleZeroValues` is an array of 128-bit entities, represented as pairs of 64-bit ones. So using array syntax is not possible.