LLVM has the habit of turning adds with no common bits set into ors, which means we need to detect them and treat them like adds again in the MVE gather/scatter lowering pass.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM with a couple of comments.
llvm/lib/Target/ARM/MVEGatherScatterLowering.cpp | ||
---|---|---|
364 | Without context, I think this function name reads as "add like an or", rather than "add-like or". I think it would be good to add a comment above it or rename it to isOrLikeAnAdd to emphasise that it's an or that is add-like. | |
1080 | Does this need to check if the OR is add-like? |
Without context, I think this function name reads as "add like an or", rather than "add-like or". I think it would be good to add a comment above it or rename it to isOrLikeAnAdd to emphasise that it's an or that is add-like.