This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][NFC] Remove autogenerated comment for test
AbandonedPublic

Authored by vangthao on Oct 29 2021, 12:17 PM.

Details

Reviewers
foad
Summary

D112733 added a non-generated test so the comment is now misleading.

Diff Detail

Event Timeline

vangthao created this revision.Oct 29 2021, 12:17 PM
vangthao requested review of this revision.Oct 29 2021, 12:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 29 2021, 12:17 PM
foad added a comment.Nov 29 2021, 2:57 AM

Actually I'd much prefer that the test still *was* autogenerated, otherwise it gets much harder to update the checks. I've run into this a few times with patches I've been working on in the last couple of weeks. Is there a good reason why the test you added in D112733 had to be non-auto-generated? Could it be split into a different file?

foad added a comment.Dec 3 2021, 4:58 AM

Not surprisingly someone has now re-auto-generated the checks in this file thus clobbering your hand written checks for cvt_f32_ubyte0_vector - see D114777.

My original intention with this test was to showcase exactly which instructions we care about but I do see the issue now in updating this test. I can remove the GFX9 check and auto-generate the test again. Will that be fine?

foad added a comment.Dec 6 2021, 2:18 AM

My original intention with this test was to showcase exactly which instructions we care about but I do see the issue now in updating this test. I can remove the GFX9 check and auto-generate the test again. Will that be fine?

Sure, but I don't think there's any need to do anything at all - now that we are testing GFX9, why not keep it?

vangthao abandoned this revision.Dec 7 2021, 1:21 PM

Sounds good to me.