Page MenuHomePhabricator

Removed unnecessary comments in flang-omp-report plugin tests
ClosedPublic

Authored by josh.mottley.arm on Oct 29 2021, 7:41 AM.

Details

Summary

This patch removes unnecessary comments in the flang-omp-report
plugin tests which can be implied from the file name and run command.
This also meant that all of the tests had to be updated due to the
tests using specific line numbers and the patch removing comments at
the top of the file.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptOct 29 2021, 7:41 AM
josh.mottley.arm requested review of this revision.Oct 29 2021, 7:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 29 2021, 7:41 AM
awarzynski accepted this revision.Nov 1 2021, 7:08 AM

Thanks @josh.mottley.arm for submitting this! Makes a lot of sense. Could you explain in the commit message "why" you had to update the tests as well? Thank you!

This revision is now accepted and ready to land.Nov 1 2021, 7:08 AM

Updated commit message.

Updated phabricator summary.

Updated phabricator summary.

josh.mottley.arm edited the summary of this revision. (Show Details)Nov 3 2021, 10:09 AM