This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] libomp: Fix handling of barrier pattern environment variables

Authored by t-msn on Oct 27 2021, 12:26 AM.



It is better to set all barrier patterns to use "dist" when at least
one environment variable specifies "dist". Otherwise if only one
environment is set to "dist" and others left blank inadvertently,
it would result in mixing dist barrier with default hyper barrier

Diff Detail

Event Timeline

t-msn created this revision.Oct 27 2021, 12:26 AM
t-msn added a subscriber: openmp-commits.
t-msn published this revision for review.Oct 27 2021, 12:35 AM

Hello, this is the first time I submitted a patch and please let me know if I misunderstood something.

Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: sstefan1. · View Herald Transcript
This revision is now accepted and ready to land.Nov 3 2021, 12:53 PM
t-msn added a comment.Nov 8 2021, 12:03 AM

As I don't have access right, would you mind committing this instead of me?