User Details
- User Since
- Oct 25 2021, 12:51 AM (101 w, 2 d)
Apr 12 2022
Follow suggestions by jlpeyton. Thanks a lot.
Apr 11 2022
I couldn't find any documents on the web. Is there any existing materials?
Apr 7 2022
Thanks for the suggestion. I tried if lit's regex can be used but got no luck. So, I decided to follow the advice.
I think it is better to separate patches and here is the patch to run barrier/reduction test for each barrier : D123359
Hi
I saw check-openmp hang on both x86 and arm64. Adding timeout value to lit option gives me the following result:
Apr 6 2022
I checked the runtime tests and found that openmp/runtime/test/barrier/omp_barrier.c already triggers different combinations of barriers. Do the combinations cover all configurations you tried manually?
Not really.
There are currently 5 barriers in libomp: linear, tree, hyper(default), hier, dist.
With manually changing barriers with this patch, I don't see any problems with linear, tree and hyper while found some in hier and dist (incl. the problems addressed by other patches I submitted).
Can you add extra run lines to openmp/runtime/test/ompt/synchronization/reduction/*_reduce.c in order to trigger the different barrier implementations?
I think, in addition to manually selecting the barrier implementation, we should add additional run lines to specific tests that trigger the different barrier implementations. I added a related, OMPT-specific comment to D123193.
I noticed this when running check-openmp with dist barrier by using https://reviews.llvm.org/D122645
btw, it seems parallel tests run does not work when using dist barrier, but I couldn't figure out the reason.
I noticed this when running check-openmp with dist barrier by using https://reviews.llvm.org/D122645
I noticed this when running check-openmp with hier barrier by using https://reviews.llvm.org/D122645
Update name to use CHECK_OPENMP_ENV and also update README
Apr 3 2022
Thanks for clarifications, I'm ok with CHECK_OPENMP_ENV.
If anyone has a different suggestion, please let me know.
Mar 31 2022
Mar 30 2022
Obviously I didn't add proper ifdef close and compile on non-arm64 architecture fails for current version. I will fix that.
Mar 29 2022
Sorry, I wrote wrong location for kernel driver. I updated summary to correct one.
Jan 16 2022
Friendly ping as this seems to have forgotten. Thanks.
Nov 25 2021
Gentle ping, or can anyone help me to commit this? Thanks.
Nov 15 2021
Thank you very much. Could I also ask you to commit this patch as I don't have right?
Nov 10 2021
I'm not sure who is the code owner of this. Could you please review this as I see you have previously review similar commit?
Nov 8 2021
As I don't have access right, would you mind committing this instead of me?
Oct 27 2021
Hello, this is the first time I submitted a patch and please let me know if I misunderstood something.