This is an archive of the discontinued LLVM Phabricator instance.

tsan: partially restore COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED check
AcceptedPublic

Authored by dvyukov on Oct 26 2021, 7:57 AM.

Details

Reviewers
vitalybuka
melver
Summary

PPC64 buildbots crashes after D112446:
https://lab.llvm.org/buildbot#builders/52/builds/11811
Restore the old check for most platforms,
let's see if it can be disabled at least for Linux/x86_64.

Depends on D112538.

Diff Detail

Event Timeline

dvyukov created this revision.Oct 26 2021, 7:57 AM
dvyukov requested review of this revision.Oct 26 2021, 7:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 26 2021, 7:57 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
melver added inline comments.Oct 26 2021, 8:01 AM
compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
158

Is there an explanation for this?
Is it the .preinit_array that isn't supported?

It would be good to explain it, otherwise it makes me think that this can equally break on other platforms.

melver added inline comments.Oct 26 2021, 8:08 AM
compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
158

s/break on other platforms/break on other Linux-based x86-64 configurations/
... which might depend on libc being used?

I also see SANITIZER_CAN_USE_PREINIT_ARRAY, which should be set correctly though. But again, .preinit_array may not be the problem and it's something else.

melver accepted this revision.Oct 26 2021, 8:09 AM
This revision is now accepted and ready to land.Oct 26 2021, 8:09 AM