This is an archive of the discontinued LLVM Phabricator instance.

tsan: turn off COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED
ClosedPublic

Authored by dvyukov on Oct 25 2021, 6:15 AM.

Details

Summary

All tsan interceptors check for initialization and/or initialize things
as necessary lazily, so we can pretend everything is initialized in the
COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED check to avoid double-checking
for initialization (this is only necessary for sanitizers that don't
handle initialization on common grounds).

Diff Detail

Event Timeline

dvyukov requested review of this revision.Oct 25 2021, 6:15 AM
dvyukov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 25 2021, 6:15 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
melver accepted this revision.Oct 25 2021, 7:02 AM
This revision is now accepted and ready to land.Oct 25 2021, 7:02 AM
This revision was landed with ongoing or failed builds.Oct 26 2021, 7:13 AM
This revision was automatically updated to reflect the committed changes.
yln added a subscriber: yln.Oct 29 2021, 10:56 AM

@vitalybuka
Hi Vitaly, this also broke a number of our bots; mostly for device simulators.
If we attempt this again, please ping me so I can test it locally before landing. :)

@dvyukov
Thanks for reverting Dmitry!