Make genAttributeVerifier escape the summary.

[matthiaskramm]

Summary

The summary can contain references to e.g. attribute defaults, which
can contain special characters. So these strings need to be C++
escaped.

[Mogball]

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

371

static functions shouldn't be inside anonymous namespaces. Move this to the top-level.

[matthiaskramm]

Move static helper function to top level.

[Mogball]

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

374

Oh actually, can you move this up to line 140 "Utility structs and functions"?

Go ahead and land it afterwards.

[matthiaskramm]

Move escapeString to the "utility structs and functions" section.

[matthiaskramm]

Jeff, could you land this one for me? I don't have commit access.

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

static std::string replaceAllSubstrs(std::string str, const std::string &match,
   std::string::size_type scanLoc = 0, matchLoc = std::string::npos;
   while ((matchLoc = str.find(match, scanLoc)) != std::string::npos) {
     str = str.replace(matchLoc, match.size(), substitute);
     scanLoc = matchLoc + substitute.size();
   }
   return str;
 }
 
+// Escape a string using LLVM/MLIR encoding. E.g. foo"bar -> foo\22bar.
+static std::string escapeString(StringRef value) {
+  std::string ret;
+  llvm::raw_string_ostream os(ret);
+  llvm::printEscapedString(value, os);
+  return os.str();
+}
+
 // Returns whether the record has a value of the given name that can be returned
 // via getValueAsString.
 static inline bool hasStringAttribute(const Record &record,
                                       StringRef fieldName) {
   auto valueInit = record.getValueInit(fieldName);
   return isa<StringInit>(valueInit);
 }
 
private:
   OpClass opClass;
 
   // The format context for verification code generation.
   FmtContext verifyCtx;
 
   // The emitter containing all of the locally emitted verification functions.
   const StaticVerifierFunctionEmitter &staticVerifierEmitter;
 };
+
 } // end anonymous namespace
 
 // Populate the format context `ctx` with substitutions of attributes, operands
 // and results.
 // - attrGet corresponds to the name of the function to call to get value of
 //   attribute (the generated function call returns an Attribute);
 // - operandGet corresponds to the name of the function with which to retrieve
 //   an operand (the generated function call returns an OperandRange);
 // - resultGet corresponds to the name of the function to get an result (the
 //   generated function call returns a ValueRange);
 static void populateSubstitutions(const Operator &op, const char *attrGet,
                                   const char *operandGet, const char *resultGet,
if (allowMissingAttr) {
       // set. This does effectively assume that the default value is valid.
       // TODO: verify the debug value is valid (perhaps in debug mode only).
       body << "  if (" << varName << ") {\n";
     }
 
     body << tgfmt("    if (!($0)) return $1\"attribute '$2' "
                   "failed to satisfy constraint: $3\");\n",
                   /*ctx=*/nullptr, tgfmt(condition, &ctx.withSelf(varName)),
-                  emitErrorPrefix, attrName, attr.getSummary());
+                  emitErrorPrefix, attrName, escapeString(attr.getSummary()));
     if (allowMissingAttr)
       body << "  }\n";
     body << "  }\n";
   }
 }
 
 OpEmitter::OpEmitter(const Operator &op,
                      const StaticVerifierFunctionEmitter &staticVerifierEmitter)