- User Since
- Feb 18 2020, 9:43 AM (154 w, 3 d)
Wed, Jan 25
Dec 12 2022
Address review comments.
Dec 6 2022
Addressed review comments.
Dec 5 2022
Nov 29 2022
Feb 23 2022
The operation should have no uses.
Try to adjust wording to incorporate both Uday's and Medhi's suggestions.
Feb 19 2022
Use Mehdi's phrasing.
It removes the node from the linked list and destroy it as far as I can tell?
For reference, the reason I don't like "delete" in this context is that Operations are stored in linked lists. But linked list nomenclature uses "delete" to mean something that's different from deallocation.
Updating phrasing according to Uday's suggestion.
Feb 18 2022
Oct 25 2021
Make opL test case slightly more realistic.
Fold namespaces into prototype.
Adjust commit description.
Thanks for the quick review!
Oct 21 2021
Jeff, could you land this one for me, as well?
Jeff, could you land this one for me? I don't have commit access.
Move escapeString to the "utility structs and functions" section.
Redoing this change, since (at least) MLIR uses \HH for hex escapes.
Adjust test case.
Move static helper function to top level.
Oct 14 2021
Apr 20 2020
Apr 17 2020
Use 'continue' instead of 'if'.
Apr 7 2020
Thanks for fixing this!
Mar 11 2020
Thanks for the fix!
Mar 3 2020
Feb 28 2020
Yes please. Thank you!
Wrapped the failed() directly around the recursive call.
Feb 27 2020
Thanks for the quick review! I don't have write access. Any chance you could submit this? (Same question for the other commits you reviewed?)
Thanks for the review, River! Fixed the nit.
Good point. Adjusted the comments instead.
Adjust commit message.
Undo, adjust comments.
Feb 20 2020
Thanks for the quick review, River! I don't have write access. Would you be able to commit this change?