Page MenuHomePhabricator

matthiaskramm (Matthias Kramm)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 18 2020, 9:43 AM (154 w, 3 d)

Recent Activity

Wed, Jan 25

matthiaskramm accepted D142544: [mlir] fix crash when call a function decl.
Wed, Jan 25, 8:05 AM · Restricted Project, Restricted Project

Dec 12 2022

matthiaskramm updated the diff for D138935: [mlir] Implement backward dataflow..

Cosmetic fixes.

Dec 12 2022, 9:25 AM · Restricted Project, Restricted Project
matthiaskramm updated the diff for D138935: [mlir] Implement backward dataflow..

Address review comments.

Dec 12 2022, 9:10 AM · Restricted Project, Restricted Project

Dec 6 2022

matthiaskramm added inline comments to D138935: [mlir] Implement backward dataflow..
Dec 6 2022, 10:58 AM · Restricted Project, Restricted Project
matthiaskramm updated the diff for D138935: [mlir] Implement backward dataflow..

Addressed review comments.

Dec 6 2022, 10:46 AM · Restricted Project, Restricted Project

Dec 5 2022

matthiaskramm added inline comments to D138935: [mlir] Implement backward dataflow..
Dec 5 2022, 8:54 AM · Restricted Project, Restricted Project

Nov 29 2022

matthiaskramm retitled D138935: [mlir] Implement backward dataflow. from [mlir] Implement backwards dataflow. to [mlir] Implement backward dataflow..
Nov 29 2022, 11:26 AM · Restricted Project, Restricted Project
matthiaskramm added a comment to D138935: [mlir] Implement backward dataflow..

See https://github.com/llvm/llvm-project/issues/57698

Nov 29 2022, 11:24 AM · Restricted Project, Restricted Project
matthiaskramm requested review of D138935: [mlir] Implement backward dataflow..
Nov 29 2022, 11:22 AM · Restricted Project, Restricted Project

Feb 23 2022

matthiaskramm added a comment to D120145: Clarify comment of erase() and remove().

The operation should have no uses.

Feb 23 2022, 11:33 AM · Restricted Project
matthiaskramm updated the diff for D120145: Clarify comment of erase() and remove().

Try to adjust wording to incorporate both Uday's and Medhi's suggestions.

Feb 23 2022, 11:31 AM · Restricted Project

Feb 19 2022

matthiaskramm added inline comments to D120145: Clarify comment of erase() and remove().
Feb 19 2022, 6:22 PM · Restricted Project
matthiaskramm updated the diff for D120145: Clarify comment of erase() and remove().

Use Mehdi's phrasing.

Feb 19 2022, 6:21 PM · Restricted Project
matthiaskramm added inline comments to D120145: Clarify comment of erase() and remove().
Feb 19 2022, 5:16 PM · Restricted Project
matthiaskramm added a comment to D120145: Clarify comment of erase() and remove().

It removes the node from the linked list and destroy it as far as I can tell?

Feb 19 2022, 4:13 PM · Restricted Project
matthiaskramm added a comment to D120145: Clarify comment of erase() and remove().

For reference, the reason I don't like "delete" in this context is that Operations are stored in linked lists. But linked list nomenclature uses "delete" to mean something that's different from deallocation.

Feb 19 2022, 1:51 PM · Restricted Project
matthiaskramm updated the diff for D120145: Clarify comment of erase() and remove().

Updating phrasing according to Uday's suggestion.

Feb 19 2022, 1:47 PM · Restricted Project

Feb 18 2022

matthiaskramm requested review of D120145: Clarify comment of erase() and remove().
Feb 18 2022, 10:14 AM · Restricted Project

Oct 25 2021

matthiaskramm updated the diff for D112468: When generating C++ code, use C++ string escaping..

Make opL test case slightly more realistic.

Oct 25 2021, 3:29 PM · Restricted Project
matthiaskramm updated the diff for D112468: When generating C++ code, use C++ string escaping..

Fold namespaces into prototype.

Oct 25 2021, 3:22 PM · Restricted Project
matthiaskramm updated the diff for D112468: When generating C++ code, use C++ string escaping..

Adjust commit description.

Oct 25 2021, 2:21 PM · Restricted Project
matthiaskramm updated the diff for D112468: When generating C++ code, use C++ string escaping..

Thanks for the quick review!

Oct 25 2021, 2:20 PM · Restricted Project
matthiaskramm requested review of D112468: When generating C++ code, use C++ string escaping..
Oct 25 2021, 10:15 AM · Restricted Project

Oct 21 2021

matthiaskramm added a comment to D112269: Fix escaping in RewriterGen.cpp..

Jeff, could you land this one for me, as well?

Oct 21 2021, 2:18 PM · Restricted Project
matthiaskramm added a comment to D112249: Make genAttributeVerifier escape the summary..

Jeff, could you land this one for me? I don't have commit access.

Oct 21 2021, 2:07 PM · Restricted Project
matthiaskramm updated the diff for D112249: Make genAttributeVerifier escape the summary..

Move escapeString to the "utility structs and functions" section.

Oct 21 2021, 2:06 PM · Restricted Project
matthiaskramm requested review of D112269: Fix escaping in RewriterGen.cpp..
Oct 21 2021, 2:04 PM · Restricted Project
matthiaskramm abandoned D112247: Fix printEscapedString: Hex escape is \xHH, not \HH..

Redoing this change, since (at least) MLIR uses \HH for hex escapes.

Oct 21 2021, 12:59 PM · Restricted Project
matthiaskramm updated the diff for D112247: Fix printEscapedString: Hex escape is \xHH, not \HH..

Adjust test case.

Oct 21 2021, 12:11 PM · Restricted Project
matthiaskramm updated the diff for D112249: Make genAttributeVerifier escape the summary..

Move static helper function to top level.

Oct 21 2021, 12:05 PM · Restricted Project
matthiaskramm requested review of D112249: Make genAttributeVerifier escape the summary..
Oct 21 2021, 11:06 AM · Restricted Project
matthiaskramm requested review of D112247: Fix printEscapedString: Hex escape is \xHH, not \HH..
Oct 21 2021, 11:00 AM · Restricted Project

Oct 14 2021

matthiaskramm awarded D111855: [MLIR][ODS] default-valued strings should be in quotes a Like token.
Oct 14 2021, 8:20 PM · Restricted Project

Apr 20 2020

matthiaskramm created D78504: [mlir] Clarify operation/block assert message..
Apr 20 2020, 10:16 AM · Restricted Project

Apr 17 2020

matthiaskramm updated the diff for D78384: [mlir] omit extra newlines if there are no aliases.

Use 'continue' instead of 'if'.

Apr 17 2020, 10:47 AM · Restricted Project
matthiaskramm created D78384: [mlir] omit extra newlines if there are no aliases.
Apr 17 2020, 10:14 AM · Restricted Project

Apr 7 2020

matthiaskramm accepted D77625: Fix a typo in the error message for an incorrect prototype..

Thanks for fixing this!

Apr 7 2020, 6:28 AM · Restricted Project

Mar 11 2020

matthiaskramm accepted D76025: [mlir][NFC] Use fold expressions instead of variadic class templates for adding operations/etc. to dialects..

Thanks for the fix!

Mar 11 2020, 3:19 PM · Restricted Project

Mar 3 2020

matthiaskramm created D75534: [mlir][Tutorial] Make parsing an empty file print a better error..
Mar 3 2020, 8:35 AM · Restricted Project

Feb 28 2020

matthiaskramm added a comment to D75369: [mlir][DialectConversion] Abort early if a subregion has a disconnected CFG..

Yes please. Thank you!

Feb 28 2020, 11:51 AM · Restricted Project
matthiaskramm updated the diff for D75369: [mlir][DialectConversion] Abort early if a subregion has a disconnected CFG..

Wrapped the failed() directly around the recursive call.

Feb 28 2020, 11:30 AM · Restricted Project
matthiaskramm added inline comments to D75369: [mlir][DialectConversion] Abort early if a subregion has a disconnected CFG..
Feb 28 2020, 11:30 AM · Restricted Project
matthiaskramm added inline comments to D75369: [mlir][DialectConversion] Abort early if a subregion has a disconnected CFG..
Feb 28 2020, 11:30 AM · Restricted Project
matthiaskramm created D75369: [mlir][DialectConversion] Abort early if a subregion has a disconnected CFG..
Feb 28 2020, 10:23 AM · Restricted Project

Feb 27 2020

matthiaskramm added a comment to D75260: Fix/clarify parts of MLIR toy tutorial chaper 4..

Thanks for the quick review! I don't have write access. Any chance you could submit this? (Same question for the other commits you reviewed?)

Feb 27 2020, 12:23 PM · Restricted Project
matthiaskramm updated the diff for D75262: Fix/Clarify parts of MLIR toy tutorial chapter 5.

Done.

Feb 27 2020, 12:23 PM · Restricted Project
matthiaskramm updated the diff for D75263: Fix/Clarify parts of MLIR toy tutorial chapter 6+7.

Thanks for the review, River! Fixed the nit.

Feb 27 2020, 12:23 PM · Restricted Project
matthiaskramm added a comment to D75264: Flip if condition of SimplifyRedundantTranspose..

Good point. Adjusted the comments instead.

Feb 27 2020, 9:25 AM · Restricted Project
matthiaskramm updated the diff for D75264: Flip if condition of SimplifyRedundantTranspose..

Adjust commit message.

Feb 27 2020, 9:24 AM · Restricted Project
matthiaskramm updated the diff for D75264: Flip if condition of SimplifyRedundantTranspose..

Undo, adjust comments.

Feb 27 2020, 9:21 AM · Restricted Project
matthiaskramm updated the diff for D75264: Flip if condition of SimplifyRedundantTranspose..

Ran clang-format.

Feb 27 2020, 9:12 AM · Restricted Project
matthiaskramm created D75264: Flip if condition of SimplifyRedundantTranspose..
Feb 27 2020, 8:32 AM · Restricted Project
matthiaskramm created D75263: Fix/Clarify parts of MLIR toy tutorial chapter 6+7.
Feb 27 2020, 8:23 AM · Restricted Project
matthiaskramm created D75262: Fix/Clarify parts of MLIR toy tutorial chapter 5.
Feb 27 2020, 8:13 AM · Restricted Project
matthiaskramm created D75260: Fix/clarify parts of MLIR toy tutorial chaper 4..
Feb 27 2020, 7:56 AM · Restricted Project
matthiaskramm created D75258: Fix comma+typo in MLIR toy tutorial chapter 3..
Feb 27 2020, 7:36 AM · Restricted Project
matthiaskramm created D75256: Clarify/Fix parts of MLIR toy tutorial chapter 2.
Feb 27 2020, 7:30 AM · Restricted Project

Feb 20 2020

matthiaskramm added a comment to D74905: Fix some typos in the MLIR documentation..

Thanks for the quick review, River! I don't have write access. Would you be able to commit this change?

Feb 20 2020, 8:39 AM · Restricted Project
matthiaskramm created D74905: Fix some typos in the MLIR documentation..
Feb 20 2020, 8:12 AM · Restricted Project
matthiaskramm added a reviewer for D74905: Fix some typos in the MLIR documentation.: rriddle.
Feb 20 2020, 8:12 AM · Restricted Project