This is an archive of the discontinued LLVM Phabricator instance.

Differential D112136

Fixed plistlib API usage
ClosedPublic

Authored by kpdev42 on Oct 20 2021, 6:13 AM.

Details

Reviewers
cmatthews
thopre
danilaml
Commits
rLNT87eb0317d4e4: Fixed plistlib API usage
Summary

plistlib API required the file object opened in the binary mode.
Test command: lnt checkformat tests/SharedInputs/sample-a-small.plist
Related to: https://reviews.llvm.org/D109235

Diff Detail

Repository
rLNT LNT

Revision Contents

PathSize
lnt/
formats/
16 lines

Diff 380930

lnt/formats/PlistFormat.py

import plistlib import plistlib
def _matches_format(path_or_file): def _matches_format(path_or_file):
try: try:
if isinstance(path_or_file, str):
with open(path_or_file, 'rb') as fp:
plistlib.load(fp)
else:
plistlib.load(path_or_file) plistlib.load(path_or_file)
return True return True
except Exception: except Exception:
return False return False
def _load_format(path_or_file):
if isinstance(path_or_file, str):
with open(path_or_file, 'rb') as fp:
return plistlib.load(fp)
else:
return plistlib.load(path_or_file)
format = { format = {
'name': 'plist', 'name': 'plist',
'predicate': _matches_format, 'predicate': _matches_format,
'read': plistlib.load, 'read': _load_format,
'write': plistlib.dump, 'write': plistlib.dump,
} }