Page MenuHomePhabricator
Differential D112153

[OpenMP] Introduce aligned synchronization into the new device RT
ClosedPublic
Actions

Authored by jdoerfert on Oct 20 2021, 9:29 AM.

Details

Reviewers
tianshilei1992
jhuber6
Commits
rGb16aadf0a79a: [OpenMP] Introduce aligned synchronization into the new device RT
Summary

We will later use the fact that a barrier is aligned to reason about
thread divergence. For now we introduce the assumption and some more
documentation.

Diff Detail

Event Timeline

jdoerfert created this revision.Oct 20 2021, 9:29 AM
Herald added subscribers: guansong, bollu, yaxunl. · View Herald TranscriptOct 20 2021, 9:29 AM
jdoerfert requested review of this revision.Oct 20 2021, 9:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2021, 9:29 AM
Herald added a subscriber: sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B129760: Diff 380994.Oct 20 2021, 9:40 AM
tianshilei1992 added inline comments.Oct 20 2021, 9:54 AM
openmp/libomptarget/DeviceRTL/src/Synchronization.cpp
186

We don't have to use a named barrier for aligned barrier, do we?

jdoerfert added inline comments.Oct 20 2021, 3:35 PM
openmp/libomptarget/DeviceRTL/src/Synchronization.cpp
186

I guess not.

jdoerfert updated this revision to Diff 381121.Oct 20 2021, 5:30 PM

use syncthreads

Harbormaster completed remote builds in B129855: Diff 381121.Oct 20 2021, 5:35 PM
JonChesterfield added a subscriber: JonChesterfield.Oct 21 2021, 12:51 AM
JonChesterfield added inline comments.
openmp/libomptarget/DeviceRTL/src/Parallelism.cpp
96–98

Thank you for the comments here

tianshilei1992 accepted this revision.Oct 22 2021, 11:41 AM

LGTM

This revision is now accepted and ready to land.Oct 22 2021, 11:41 AM
Closed by commit rGb16aadf0a79a: [OpenMP] Introduce aligned synchronization into the new device RT (authored by jdoerfert). · Explain WhyOct 27 2021, 4:22 PM
This revision was automatically updated to reflect the committed changes.
jdoerfert added a commit: rGb16aadf0a79a: [OpenMP] Introduce aligned synchronization into the new device RT.
JonChesterfield mentioned this in rGcf37a94c1e42: [openmp] Add amdgpu impl missed from D112153.Oct 27 2021, 4:56 PM
jdoerfert mentioned this in D131628: [LangRef] Add description for nocallback attribute.Thu, Aug 11, 8:11 AM

Revision Contents
Changeset List

PathSize
openmp/
libomptarget/
DeviceRTL/
include/
15 lines
src/
2 lines
27 lines
4 lines
10 lines

Diff 382846

View Options

openmp/libomptarget/DeviceRTL/include/Synchronization.h

Loading...
View Options

openmp/libomptarget/DeviceRTL/src/Kernel.cpp

Loading...
View Options

openmp/libomptarget/DeviceRTL/src/Parallelism.cpp

Loading...
View Options

openmp/libomptarget/DeviceRTL/src/State.cpp

Loading...
View Options

openmp/libomptarget/DeviceRTL/src/Synchronization.cpp

Loading...